Browse Source

Print a warning when the engine is started as `root`/superuser

This is a security risk (especially when hosting a game server)
and can make audio non-functional on Linux.
Hugo Locurcio 4 years ago
parent
commit
9c34db6cb4
1 changed files with 7 additions and 0 deletions
  1. 7 0
      main/main.cpp

+ 7 - 0
main/main.cpp

@@ -1596,6 +1596,13 @@ Error Main::setup2(Thread::ID p_main_tid_override) {
 		rendering_server->set_print_gpu_profile(true);
 	}
 
+#ifdef UNIX_ENABLED
+	// Print warning after initializing the renderer but before initializing audio.
+	if (OS::get_singleton()->get_environment("USER") == "root" && !OS::get_singleton()->has_environment("GODOT_SILENCE_ROOT_WARNING")) {
+		WARN_PRINT("Started the engine as `root`/superuser. This is a security risk, and subsystems like audio may not work correctly.\nSet the environment variable `GODOT_SILENCE_ROOT_WARNING` to 1 to silence this warning.");
+	}
+#endif
+
 	OS::get_singleton()->initialize_joypads();
 
 	/* Initialize Audio Driver */