Browse Source

Fixed mistake where available buffer size would not be updated for each recvfrom-call in PacketPeerUDPWinsockPposix.

Trond Abusdal 9 years ago
parent
commit
a8a2458f0b

+ 1 - 3
drivers/unix/packet_peer_udp_posix.cpp

@@ -120,10 +120,8 @@ Error PacketPeerUDPPosix::_poll(bool p_wait) {
 
 	struct sockaddr_in from = {0};
 	socklen_t len = sizeof(struct sockaddr_in);
-	int rb_size = MAX(rb.space_left()-12, 0);
-	int buffer_size = MIN((int)sizeof(recv_buffer),rb_size);
 	int ret;
-	while ( (ret = recvfrom(sockfd, recv_buffer, buffer_size, p_wait?0:MSG_DONTWAIT, (struct sockaddr*)&from, &len)) > 0) {
+	while ( (ret = recvfrom(sockfd, recv_buffer, MIN((int)sizeof(recv_buffer),MAX(rb.space_left()-12, 0)), p_wait?0:MSG_DONTWAIT, (struct sockaddr*)&from, &len)) > 0) {
 		rb.write((uint8_t*)&from.sin_addr, 4);
 		uint32_t port = ntohs(from.sin_port);
 		rb.write((uint8_t*)&port, 4);

+ 1 - 3
platform/windows/packet_peer_udp_winsock.cpp

@@ -120,10 +120,8 @@ Error PacketPeerUDPWinsock::_poll(bool p_wait) {
 
 	struct sockaddr_in from = {0};
 	int len = sizeof(struct sockaddr_in);
-	int rb_size = MAX(rb.space_left()-12, 0);
-	int buffer_size = MIN((int)sizeof(recv_buffer),rb_size);
 	int ret;
-	while ( (ret = recvfrom(sockfd, (char*)recv_buffer, buffer_size, 0, (struct sockaddr*)&from, &len)) > 0) {
+	while ( (ret = recvfrom(sockfd, (char*)recv_buffer, MIN((int)sizeof(recv_buffer),MAX(rb.space_left()-12, 0)), 0, (struct sockaddr*)&from, &len)) > 0) {
 		rb.write((uint8_t*)&from.sin_addr, 4);
 		uint32_t port = ntohs(from.sin_port);
 		rb.write((uint8_t*)&port, 4);