Răsfoiți Sursa

Fixed error messages when setting all_tab_in_front of TabContainer

Some signal handlers weren't unregistered when removing the wrapped
child TabBar, which resulted in errors printed when the TabBar was
removed and added again when the flag was updated
Tefatika 2 ani în urmă
părinte
comite
abd894daf7
1 a modificat fișierele cu 4 adăugiri și 4 ștergeri
  1. 4 4
      scene/gui/tab_container.cpp

+ 4 - 4
scene/gui/tab_container.cpp

@@ -564,12 +564,12 @@ void TabContainer::add_child_notify(Node *p_child) {
 }
 
 void TabContainer::move_child_notify(Node *p_child) {
+	Container::move_child_notify(p_child);
+
 	if (p_child == tab_bar) {
 		return;
 	}
 
-	Container::move_child_notify(p_child);
-
 	Control *c = Object::cast_to<Control>(p_child);
 	if (c && !c->is_set_as_top_level()) {
 		int old_idx = -1;
@@ -588,12 +588,12 @@ void TabContainer::move_child_notify(Node *p_child) {
 }
 
 void TabContainer::remove_child_notify(Node *p_child) {
+	Container::remove_child_notify(p_child);
+
 	if (p_child == tab_bar) {
 		return;
 	}
 
-	Container::remove_child_notify(p_child);
-
 	Control *c = Object::cast_to<Control>(p_child);
 	if (!c || c->is_set_as_top_level()) {
 		return;