Browse Source

Merge pull request #88931 from clayjohn/GLTF-normals

Fix wrong indexing when generating dummy tangents in GLTF import
Rémi Verschelde 1 year ago
parent
commit
ac4376814b
1 changed files with 1 additions and 1 deletions
  1. 1 1
      modules/gltf/gltf_document.cpp

+ 1 - 1
modules/gltf/gltf_document.cpp

@@ -2796,7 +2796,7 @@ Error GLTFDocument::_parse_meshes(Ref<GLTFState> p_state) {
 
 				Vector<Vector3> normals = array[Mesh::ARRAY_NORMAL];
 				for (int k = 0; k < vertex_num; k++) {
-					Vector3 tan = Vector3(normals[i].z, -normals[i].x, normals[i].y).cross(normals[k].normalized()).normalized();
+					Vector3 tan = Vector3(normals[k].z, -normals[k].x, normals[k].y).cross(normals[k].normalized()).normalized();
 					tangentsw[k * 4 + 0] = tan.x;
 					tangentsw[k * 4 + 1] = tan.y;
 					tangentsw[k * 4 + 2] = tan.z;