Browse Source

Merge pull request #50925 from timothyqiu/internal-checks

Add checks to internal methods to prevent crash
Rémi Verschelde 4 years ago
parent
commit
ae1b124e14
2 changed files with 2 additions and 0 deletions
  1. 1 0
      scene/2d/tile_map.cpp
  2. 1 0
      scene/3d/proximity_group_3d.cpp

+ 1 - 0
scene/2d/tile_map.cpp

@@ -795,6 +795,7 @@ void TileMap::_set_tile_data(const Vector<int> &p_data) {
 	const int *r = p_data.ptr();
 
 	int offset = (format >= FORMAT_2) ? 3 : 2;
+	ERR_FAIL_COND_MSG(c % offset != 0, "Corrupted tile data.");
 
 	clear();
 

+ 1 - 0
scene/3d/proximity_group_3d.cpp

@@ -128,6 +128,7 @@ void ProximityGroup3D::broadcast(String p_method, Variant p_parameters) {
 
 void ProximityGroup3D::_proximity_group_broadcast(String p_method, Variant p_parameters) {
 	if (dispatch_mode == MODE_PROXY) {
+		ERR_FAIL_COND(!is_inside_tree());
 		get_parent()->call(p_method, p_parameters);
 	} else {
 		emit_signal(SNAME("broadcast"), p_method, p_parameters);