Browse Source

Merge pull request #71528 from snakept/missing-path-external-editor-error

Checking path variable if empty before opening external editor to fix…
Rémi Verschelde 2 years ago
parent
commit
ae766558f0
1 changed files with 7 additions and 4 deletions
  1. 7 4
      editor/plugins/script_editor_plugin.cpp

+ 7 - 4
editor/plugins/script_editor_plugin.cpp

@@ -2256,11 +2256,14 @@ bool ScriptEditor::edit(const Ref<Resource> &p_resource, int p_line, int p_col,
 			args.push_back(script_path);
 		}
 
-		Error err = OS::get_singleton()->create_process(path, args);
-		if (err == OK) {
-			return false;
+		if (!path.is_empty()) {
+			Error err = OS::get_singleton()->create_process(path, args);
+			if (err == OK) {
+				return false;
+			}
 		}
-		WARN_PRINT("Couldn't open external text editor, using internal");
+
+		ERR_PRINT("Couldn't open external text editor, falling back to the internal editor. Review your `text_editor/external/` editor settings.");
 	}
 
 	for (int i = 0; i < tab_container->get_tab_count(); i++) {