Procházet zdrojové kódy

Use safer `add_theme_constant_override()` in MarginContainer code sample

Control has magic setters to set custom theme items, but using the
dedicated Control methods is less prone to typos so it should be favored.
Hugo Locurcio před 4 roky
rodič
revize
af513344ce
1 změnil soubory, kde provedl 11 přidání a 9 odebrání
  1. 11 9
      doc/classes/MarginContainer.xml

+ 11 - 9
doc/classes/MarginContainer.xml

@@ -5,21 +5,23 @@
 	</brief_description>
 	</brief_description>
 	<description>
 	<description>
 		Adds a top, left, bottom, and right margin to all [Control] nodes that are direct children of the container. To control the [MarginContainer]'s margin, use the [code]margin_*[/code] theme properties listed below.
 		Adds a top, left, bottom, and right margin to all [Control] nodes that are direct children of the container. To control the [MarginContainer]'s margin, use the [code]margin_*[/code] theme properties listed below.
-		[b]Note:[/b] Be careful, [Control] margin values are different than the constant margin values. If you want to change the custom margin values of the [MarginContainer] by code, you should use the following examples:
+		[b]Note:[/b] Be careful, [Control] margin values are different from the constant margin values. If you want to change the custom margin values of the [MarginContainer] by code, you should use the following examples:
 		[codeblocks]
 		[codeblocks]
 		[gdscript]
 		[gdscript]
+		# This code sample assumes the current script is extending MarginContainer.
 		var margin_value = 100
 		var margin_value = 100
-		set("custom_constants/margin_top", margin_value)
-		set("custom_constants/margin_left", margin_value)
-		set("custom_constants/margin_bottom", margin_value)
-		set("custom_constants/margin_right", margin_value)
+		add_theme_constant_override("margin_top", margin_value)
+		add_theme_constant_override("margin_left", margin_value)
+		add_theme_constant_override("margin_bottom", margin_value)
+		add_theme_constant_override("margin_right", margin_value)
 		[/gdscript]
 		[/gdscript]
 		[csharp]
 		[csharp]
+		// This code sample assumes the current script is extending MarginContainer.
 		int marginValue = 100;
 		int marginValue = 100;
-		Set("custom_constants/margin_top", marginValue);
-		Set("custom_constants/margin_left", marginValue);
-		Set("custom_constants/margin_bottom", marginValue);
-		Set("custom_constants/margin_right", marginValue);
+		AddThemeConstantOverride("margin_top", marginValue);
+		AddThemeConstantOverride("margin_left", marginValue);
+		AddThemeConstantOverride("margin_bottom", marginValue);
+		AddThemeConstantOverride("margin_right", marginValue);
 		[/csharp]
 		[/csharp]
 		[/codeblocks]
 		[/codeblocks]
 	</description>
 	</description>