Browse Source

Merge pull request #74895 from smix8/gridmap_navrid_error_spam_3.x

[3.5+] Fix GridMap free navigation RID error spam
lawnjelly 2 years ago
parent
commit
b0c399ec8c
1 changed files with 4 additions and 1 deletions
  1. 4 1
      modules/gridmap/grid_map.cpp

+ 4 - 1
modules/gridmap/grid_map.cpp

@@ -473,7 +473,10 @@ bool GridMap::_octant_update(const OctantKey &p_key) {
 
 	//erase navigation
 	for (Map<IndexKey, Octant::NavMesh>::Element *E = g.navmesh_ids.front(); E; E = E->next()) {
-		NavigationServer::get_singleton()->free(E->get().region);
+		if (E->get().region.is_valid()) {
+			NavigationServer::get_singleton()->free(E->get().region);
+			E->get().region = RID();
+		}
 		if (E->get().navmesh_debug_instance.is_valid()) {
 			VS::get_singleton()->free(E->get().navmesh_debug_instance);
 		}