Browse Source

Error running Expression.execute after parse error

There happens a segmentation fault when you use Expression.parse() and you don't check for errors and then run Expression.execute(). So we check if there was a parse error in the execute method now.
santouits 6 years ago
parent
commit
b0df0b46ac
1 changed files with 4 additions and 0 deletions
  1. 4 0
      core/math/expression.cpp

+ 4 - 0
core/math/expression.cpp

@@ -2120,6 +2120,10 @@ Error Expression::parse(const String &p_expression, const Vector<String> &p_inpu
 }
 
 Variant Expression::execute(Array p_inputs, Object *p_base, bool p_show_error) {
+	if (error_set) {
+		ERR_EXPLAIN("There was previously a parse error: " + error_str);
+		ERR_FAIL_V(Variant());
+	}
 
 	execution_error = false;
 	Variant output;