Browse Source

Merge pull request #41844 from madmiraal/fix-bitwise-sign-check

Use != 0 instead of > 0 when checking bit mask.
Rémi Verschelde 5 years ago
parent
commit
b4a831b42e
1 changed files with 1 additions and 1 deletions
  1. 1 1
      scene/gui/base_button.cpp

+ 1 - 1
scene/gui/base_button.cpp

@@ -60,7 +60,7 @@ void BaseButton::_gui_input(Ref<InputEvent> p_event) {
 	Ref<InputEventMouseButton> mouse_button = p_event;
 	Ref<InputEventMouseButton> mouse_button = p_event;
 	bool ui_accept = p_event->is_action("ui_accept") && !p_event->is_echo();
 	bool ui_accept = p_event->is_action("ui_accept") && !p_event->is_echo();
 
 
-	bool button_masked = mouse_button.is_valid() && ((1 << (mouse_button->get_button_index() - 1)) & button_mask) > 0;
+	bool button_masked = mouse_button.is_valid() && ((1 << (mouse_button->get_button_index() - 1)) & button_mask) != 0;
 	if (button_masked || ui_accept) {
 	if (button_masked || ui_accept) {
 		on_action_event(p_event);
 		on_action_event(p_event);
 		return;
 		return;