瀏覽代碼

Fixed error messages when setting all_tab_in_front of TabContainer

Some signal handlers weren't unregistered when removing the wrapped
child TabBar, which resulted in errors printed when the TabBar was
removed and added again when the flag was updated

(cherry picked from commit abd894daf794828986b9450cf7d0ef50d37dab06)
Tefatika 2 年之前
父節點
當前提交
b532dd7626
共有 1 個文件被更改,包括 4 次插入4 次删除
  1. 4 4
      scene/gui/tab_container.cpp

+ 4 - 4
scene/gui/tab_container.cpp

@@ -547,12 +547,12 @@ void TabContainer::add_child_notify(Node *p_child) {
 }
 
 void TabContainer::move_child_notify(Node *p_child) {
+	Container::move_child_notify(p_child);
+
 	if (p_child == tab_bar) {
 		return;
 	}
 
-	Container::move_child_notify(p_child);
-
 	Control *c = Object::cast_to<Control>(p_child);
 	if (c && !c->is_set_as_top_level()) {
 		int old_idx = -1;
@@ -571,12 +571,12 @@ void TabContainer::move_child_notify(Node *p_child) {
 }
 
 void TabContainer::remove_child_notify(Node *p_child) {
+	Container::remove_child_notify(p_child);
+
 	if (p_child == tab_bar) {
 		return;
 	}
 
-	Container::remove_child_notify(p_child);
-
 	Control *c = Object::cast_to<Control>(p_child);
 	if (!c || c->is_set_as_top_level()) {
 		return;