Browse Source

logic error in gdscript_parser.cpp for-loop-range

there was a logic error in for loop range argument that
check if all of the argument were constants, fixed
Thakee Nathees 5 years ago
parent
commit
bcbcf0f1ea
1 changed files with 3 additions and 3 deletions
  1. 3 3
      modules/gdscript/gdscript_parser.cpp

+ 3 - 3
modules/gdscript/gdscript_parser.cpp

@@ -3102,18 +3102,18 @@ void GDScriptParser::_parse_block(BlockNode *p_block, bool p_static) {
 						Vector<Node *> args;
 						Vector<double> constants;
 
-						bool constant = false;
+						bool constant = true;
 
 						for (int i = 1; i < op->arguments.size(); i++) {
 							args.push_back(op->arguments[i]);
-							if (constant && op->arguments[i]->type == Node::TYPE_CONSTANT) {
+							if (op->arguments[i]->type == Node::TYPE_CONSTANT) {
 								ConstantNode *c = static_cast<ConstantNode *>(op->arguments[i]);
 								if (c->value.get_type() == Variant::FLOAT || c->value.get_type() == Variant::INT) {
 									constants.push_back(c->value);
-									constant = true;
 								}
 							} else {
 								constant = false;
+								break;
 							}
 						}