Browse Source

Merge pull request #52284 from Calinou/tscn-groups-write-single-line

Write node groups on a single line when saving a `.tscn` file
Juan Linietsky 4 years ago
parent
commit
be5c75b007
1 changed files with 8 additions and 2 deletions
  1. 8 2
      scene/resources/resource_format_text.cpp

+ 8 - 2
scene/resources/resource_format_text.cpp

@@ -1849,10 +1849,16 @@ Error ResourceFormatSaverTextInstance::save(const String &p_path, const RES &p_r
 			}
 
 			if (groups.size()) {
+				// Write all groups on the same line as they're part of a section header.
+				// This improves readability while not impacting VCS friendliness too much,
+				// since it's rare to have more than 5 groups assigned to a single node.
 				groups.sort_custom<StringName::AlphCompare>();
-				String sgroups = " groups=[\n";
+				String sgroups = " groups=[";
 				for (int j = 0; j < groups.size(); j++) {
-					sgroups += "\"" + String(groups[j]).c_escape() + "\",\n";
+					sgroups += "\"" + String(groups[j]).c_escape() + "\"";
+					if (j < groups.size() - 1) {
+						sgroups += ", ";
+					}
 				}
 				sgroups += "]";
 				header += sgroups;