2
0
Эх сурвалжийг харах

this failed on mingw on linux (but not on msvc) with 2 problems:

1) it didn't print the error to the console, only this:

build_res_file(["platform/windows/godot_res.windows.tools.32.o"], ["platform/windows/godot_res.rc"])
scons: *** [platform/windows/godot_res.windows.tools.32.o] Error 1

I had to print the actual command and run it on a console to see the error. The builder should be able to print the command it's running and the error, like it does with compiler invocations, etc.

2) The actual error was a syntax error on line 11 of godot_res.rc. I looked up "FILEVERSION" and "PRODUCTVERSION" (here https://msdn.microsoft.com/en-us/library/windows/desktop/aa381058(v=vs.85).aspx), it says they take 4 numbers as parameters, so I added those 0s, but I'm not sure if they're in the right order.

@masoudbh3 can you check it out? thanks

It builds on msvc just fine with (and without) these changes.
Ariel Manzur 9 жил өмнө
parent
commit
bec1e003e7

+ 3 - 3
platform/windows/godot_res.rc

@@ -7,8 +7,8 @@
 GODOT_ICON ICON platform/windows/godot.ico
 
 1 VERSIONINFO
-FILEVERSION    	VERSION_MAJOR,VERSION_MINOR,0
-PRODUCTVERSION 	VERSION_MAJOR,VERSION_MINOR,0
+FILEVERSION    	VERSION_MAJOR,0,VERSION_MINOR,0
+PRODUCTVERSION 	VERSION_MAJOR,0,VERSION_MINOR,0
 FILEOS         	4
 FILETYPE       	1
 BEGIN
@@ -30,4 +30,4 @@ BEGIN
     BEGIN
         VALUE "Translation", 0x409, 1200
     END
-END
+END