Browse Source

Fix the `generate_apk` logic when `dev_build` or `debug_symbols` are enabled

Co-authored-by: Rémi Verschelde <[email protected]>
Fredia Huya-Kouadio 1 year ago
parent
commit
c1acddfeb4
1 changed files with 12 additions and 19 deletions
  1. 12 19
      platform/android/SCsub

+ 12 - 19
platform/android/SCsub

@@ -95,25 +95,18 @@ if lib_arch_dir != "":
         else:
         else:
             gradle_process = ["./gradlew"]
             gradle_process = ["./gradlew"]
 
 
-        if env["target"] != "editor" and env["dev_build"]:
-            subprocess.run(
-                gradle_process
-                + [
-                    "generateDevTemplate",
-                    "--quiet",
-                ],
-                cwd="platform/android/java",
-            )
-        else:
-            # Android editor with `dev_build=yes` is handled by the `generateGodotEditor` task.
-            subprocess.run(
-                gradle_process
-                + [
-                    "generateGodotEditor" if env["target"] == "editor" else "generateGodotTemplates",
-                    "--quiet",
-                ],
-                cwd="platform/android/java",
-            )
+        gradle_process += [
+            "generateGodotEditor" if env["target"] == "editor" else "generateGodotTemplates",
+            "--quiet",
+        ]
+
+        if env["debug_symbols"]:
+            gradle_process += ["-PdoNotStrip=true"]
+
+        subprocess.run(
+            gradle_process,
+            cwd="platform/android/java",
+        )
 
 
     if env["generate_apk"]:
     if env["generate_apk"]:
         generate_apk_command = env_android.Command("generate_apk", [], generate_apk)
         generate_apk_command = env_android.Command("generate_apk", [], generate_apk)