Browse Source

Fix possible buffer overflow in NetworkedMultiplayerENet

NetworkedMultiplayerENet::get_packet was reporting the wrong size for the packet buffer exposing a potential buffer overflow in case of malformed/malicious packets
Fabio Alessandrelli 9 years ago
parent
commit
c1dc71baee
1 changed files with 1 additions and 1 deletions
  1. 1 1
      modules/enet/networked_multiplayer_enet.cpp

+ 1 - 1
modules/enet/networked_multiplayer_enet.cpp

@@ -359,7 +359,7 @@ Error NetworkedMultiplayerENet::get_packet(const uint8_t **r_buffer,int &r_buffe
 	incoming_packets.pop_front();
 
 	*r_buffer=(const uint8_t*)(&current_packet.packet->data[12]);
-	r_buffer_size=current_packet.packet->dataLength;
+	r_buffer_size=current_packet.packet->dataLength-12;
 
 	return OK;
 }