Browse Source

Merge pull request #39850 from adamreichold/is-position-behind-get-global-transform-once

Call Node3D::get_global_transform and Vector3::dot only once within Camera3D::is_position_behind
Rémi Verschelde 5 years ago
parent
commit
c4707bd71b
1 changed files with 2 additions and 2 deletions
  1. 2 2
      scene/3d/camera_3d.cpp

+ 2 - 2
scene/3d/camera_3d.cpp

@@ -318,8 +318,8 @@ Vector3 Camera3D::project_ray_origin(const Point2 &p_pos) const {
 
 bool Camera3D::is_position_behind(const Vector3 &p_pos) const {
 	Transform t = get_global_transform();
-	Vector3 eyedir = -get_global_transform().basis.get_axis(2).normalized();
-	return eyedir.dot(p_pos) < (eyedir.dot(t.origin) + near);
+	Vector3 eyedir = -t.basis.get_axis(2).normalized();
+	return eyedir.dot(p_pos - t.origin) < near;
 }
 
 Vector<Vector3> Camera3D::get_near_plane_points() const {