Browse Source

Core: Identity compare objects by id, not by pointers

Dmitrii Maganov 2 years ago
parent
commit
c5f7a89b0f
2 changed files with 9 additions and 1 deletions
  1. 1 1
      core/variant/variant.cpp
  2. 8 0
      tests/core/variant/test_variant.h

+ 1 - 1
core/variant/variant.cpp

@@ -3499,7 +3499,7 @@ bool Variant::identity_compare(const Variant &p_variant) const {
 
 	switch (type) {
 		case OBJECT: {
-			return _get_obj().obj == p_variant._get_obj().obj;
+			return _get_obj().id == p_variant._get_obj().id;
 		} break;
 
 		case DICTIONARY: {

+ 8 - 0
tests/core/variant/test_variant.h

@@ -1056,6 +1056,14 @@ TEST_CASE("[Variant] Identity comparison") {
 	Variant obj_null_two_var = Variant((Object *)nullptr);
 	CHECK(obj_null_one_var.identity_compare(obj_null_one_var));
 	CHECK(obj_null_one_var.identity_compare(obj_null_two_var));
+
+	Object *freed_one = new Object();
+	Variant freed_one_var = freed_one;
+	delete freed_one;
+	Object *freed_two = new Object();
+	Variant freed_two_var = freed_two;
+	delete freed_two;
+	CHECK_FALSE(freed_one_var.identity_compare(freed_two_var));
 }
 
 TEST_CASE("[Variant] Nested array comparison") {