Revert "minimp3: Add a .cpp file to simplify building the single-header implementation"

This reverts commit 6fc09121378d78026f799a820ce689f2d30bb0c9.

modules/minimp3/SCsub

@@ -5,27 +5,13 @@ Import("env_modules")
 
 env_minimp3 = env_modules.Clone()
 
-# Thirdparty source files
-
-thirdparty_obj = []
-
 thirdparty_dir = "#thirdparty/minimp3/"
-thirdparty_sources = [thirdparty_dir + "minimp3_ex.cpp"]
-
-env_minimp3.Prepend(CPPPATH=[thirdparty_dir])
-
-env_thirdparty = env_minimp3.Clone()
-env_thirdparty.disable_warnings()
-env_thirdparty.add_source_files(thirdparty_obj, thirdparty_sources)
-env.modules_sources += thirdparty_obj
 
+# Treat minimp3 headers as system headers to avoid raising warnings. Not supported on MSVC.
+if not env.msvc:
+    env_minimp3.Append(CPPFLAGS=["-isystem", Dir(thirdparty_dir).path])
+else:
+    env_minimp3.Prepend(CPPPATH=[thirdparty_dir])
 
 # Godot source files
-
-module_obj = []
-
-env_minimp3.add_source_files(module_obj, "*.cpp")
-env.modules_sources += module_obj
-
-# Needed to force rebuilding the module files when the thirdparty library is updated.
-env.Depends(module_obj, thirdparty_obj)
+env_minimp3.add_source_files(env.modules_sources, "*.cpp")

modules/minimp3/audio_stream_mp3.cpp

@@ -28,6 +28,11 @@
 /* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.                 */
 /**************************************************************************/
 
+#define MINIMP3_ONLY_MP3
+#define MINIMP3_FLOAT_OUTPUT
+#define MINIMP3_IMPLEMENTATION
+#define MINIMP3_NO_STDIO
+
 #include "audio_stream_mp3.h"
 
 #include "core/io/file_access.h"

thirdparty/README.md

@@ -416,7 +416,6 @@ Files extracted from upstream repository:
 
 Some changes have been made in order to fix Windows on ARM build errors, and
 to solve some MSVC warnings. See the patches in the `patches` directory.
-`minimp3_ex.cpp` was created to simplify the use of the single header library.
 
 
 ## miniupnpc

thirdparty/minimp3/minimp3_ex.cpp

@@ -1,5 +0,0 @@
-#define MINIMP3_IMPLEMENTATION
-#define MINIMP3_FLOAT_OUTPUT
-#define MINIMP3_ONLY_MP3
-#define MINIMP3_NO_STDIO
-#include "minimp3_ex.h"