Browse Source

Merge pull request #102692 from a-johnston/avoid_preview_error_for_animation_node

Prevent off-thread errors when generating resource previews for animation nodes
Rémi Verschelde 6 months ago
parent
commit
caaa3e5f4b
1 changed files with 2 additions and 1 deletions
  1. 2 1
      editor/plugins/animation_tree_editor_plugin.cpp

+ 2 - 1
editor/plugins/animation_tree_editor_plugin.cpp

@@ -234,7 +234,8 @@ bool AnimationTreeEditor::can_edit(const Ref<AnimationNode> &p_node) const {
 }
 
 Vector<String> AnimationTreeEditor::get_animation_list() {
-	if (!singleton->tree || !singleton->is_visible()) {
+	// This can be called off the main thread due to resource preview generation. Quit early in that case.
+	if (!singleton->tree || !Thread::is_main_thread() || !singleton->is_visible()) {
 		// When tree is empty, singleton not in the main thread.
 		return Vector<String>();
 	}