Browse Source

[JS] Add flag to disable weak symbols in ZSTD.

Weak symbols are currently broken in upstream emscripten.

(cherry picked from commit 070bd87aaaf7a15ad9d2d839182f14d5c352153b)
Fabio Alessandrelli 3 years ago
parent
commit
cc12c69ea1
1 changed files with 2 additions and 0 deletions
  1. 2 0
      platform/javascript/detect.py

+ 2 - 0
platform/javascript/detect.py

@@ -201,6 +201,8 @@ def configure(env):
             sys.exit(255)
         env.Append(CCFLAGS=["-s", "RELOCATABLE=1"])
         env.Append(LINKFLAGS=["-s", "RELOCATABLE=1"])
+        # Weak symbols are broken upstream: https://github.com/emscripten-core/emscripten/issues/12819
+        env.Append(CPPDEFINES=["ZSTD_HAVE_WEAK_SYMBOLS=0"])
         env.extra_suffix = ".gdnative" + env.extra_suffix
 
     # Reduce code size by generating less support code (e.g. skip NodeJS support).