Browse Source

Merge pull request #23256 from JFonS/fix_17989

Fix editor only lights
Rémi Verschelde 6 years ago
parent
commit
d42fd8fa79
1 changed files with 2 additions and 7 deletions
  1. 2 7
      scene/3d/light.cpp

+ 2 - 7
scene/3d/light.cpp

@@ -163,11 +163,6 @@ void Light::_update_visibility() {
 	if (!is_inside_tree())
 		return;
 
-	// FIXME: Since the call to VS::instance_light_set_enabled was disabled below,
-	// the whole logic became pointless so editor_ok triggers unused variable warnings.
-	// Commenting out for now but this should be fixed/reimplemented so that editor_only
-	// works as expected (GH-17989).
-	/*
 	bool editor_ok = true;
 
 #ifdef TOOLS_ENABLED
@@ -184,8 +179,8 @@ void Light::_update_visibility() {
 	}
 #endif
 
-	//VS::get_singleton()->instance_light_set_enabled(get_instance(),is_visible_in_tree() && editor_ok);
-	*/
+	VS::get_singleton()->instance_set_visible(get_instance(), is_visible_in_tree() && editor_ok);
+
 	_change_notify("geometry/visible");
 }