Browse Source

Merge pull request #111327 from Ivorforce/gdvirtual-shorten-get-method-info

Simplify `gdvirtual.gen.inc` `_get_method_info` arguments with a helper function.
Thaddeus Crews 2 days ago
parent
commit
d61cd9149a
1 changed files with 15 additions and 4 deletions
  1. 15 4
      core/object/make_virtuals.py

+ 15 - 4
core/object/make_virtuals.py

@@ -127,6 +127,15 @@ def generate_version(argcount, const=False, returns=False, required=False, compa
         callsiargs = f"Variant vargs[{argcount}] = {{ "
         callsiargs = f"Variant vargs[{argcount}] = {{ "
         callsiargptrs = f"\t\t\tconst Variant *vargptrs[{argcount}] = {{ "
         callsiargptrs = f"\t\t\tconst Variant *vargptrs[{argcount}] = {{ "
         callptrargsptr = f"\t\t\tGDExtensionConstTypePtr argptrs[{argcount}] = {{ "
         callptrargsptr = f"\t\t\tGDExtensionConstTypePtr argptrs[{argcount}] = {{ "
+
+        if method_info:
+            method_info += "\\\n\t\t"
+        method_info += (
+            "_gdvirtual_set_method_info_args<"
+            + ", ".join(f"m_type{i + 1}" for i in range(argcount))
+            + ">(method_info);"
+        )
+
     callptrargs = ""
     callptrargs = ""
     for i in range(argcount):
     for i in range(argcount):
         if i > 0:
         if i > 0:
@@ -144,10 +153,6 @@ def generate_version(argcount, const=False, returns=False, required=False, compa
             f"PtrToArg<m_type{i + 1}>::EncodeT argval{i + 1} = (PtrToArg<m_type{i + 1}>::EncodeT)arg{i + 1};\\\n"
             f"PtrToArg<m_type{i + 1}>::EncodeT argval{i + 1} = (PtrToArg<m_type{i + 1}>::EncodeT)arg{i + 1};\\\n"
         )
         )
         callptrargsptr += f"&argval{i + 1}"
         callptrargsptr += f"&argval{i + 1}"
-        if method_info:
-            method_info += "\\\n\t\t"
-        method_info += f"method_info.arguments.push_back(GetTypeInfo<m_type{i + 1}>::get_class_info());\\\n"
-        method_info += f"\t\tmethod_info.arguments_metadata.push_back(GetTypeInfo<m_type{i + 1}>::METADATA);"
 
 
     if argcount:
     if argcount:
         callsiargs += " };\\\n"
         callsiargs += " };\\\n"
@@ -197,6 +202,12 @@ def run(target, source, env):
 
 
 inline constexpr uintptr_t _INVALID_GDVIRTUAL_FUNC_ADDR = static_cast<uintptr_t>(-1);
 inline constexpr uintptr_t _INVALID_GDVIRTUAL_FUNC_ADDR = static_cast<uintptr_t>(-1);
 
 
+template <typename... Args>
+void _gdvirtual_set_method_info_args(MethodInfo &p_method_info) {
+	p_method_info.arguments = { GetTypeInfo<Args>::get_class_info()... };
+	p_method_info.arguments_metadata = { GetTypeInfo<Args>::METADATA... };
+}
+
 """
 """
 
 
     for i in range(max_versions + 1):
     for i in range(max_versions + 1):