浏览代码

Fix incorrect condition for error filtering

Fixes: #87643

The original condition stopped immediately after checking for 'searchText' in the 'Message' field, resulting in premature termination of subsequent checks. This fix ensures that all relevant conditions are appropriately evaluated before determining the filtering outcome.

Additionally, accompanying changes include improved code readability for better comprehension. This adjustment enhances the maintainability of the error filtering mechanism, contributing to a more robust codebase overall.
Nông Văn Tình 1 年之前
父节点
当前提交
d81c9c32c5
共有 1 个文件被更改,包括 8 次插入8 次删除
  1. 8 8
      modules/mono/editor/GodotTools/GodotTools/Build/BuildProblemsView.cs

+ 8 - 8
modules/mono/editor/GodotTools/GodotTools/Build/BuildProblemsView.cs

@@ -308,14 +308,14 @@ namespace GodotTools.Build
                 return false;
 
             string searchText = _searchBox.Text;
-            if (!string.IsNullOrEmpty(searchText) &&
-                (!diagnostic.Message.Contains(searchText, StringComparison.OrdinalIgnoreCase) ||
-                !(diagnostic.File?.Contains(searchText, StringComparison.OrdinalIgnoreCase) ?? false)))
-            {
-                return false;
-            }
-
-            return true;
+            if (string.IsNullOrEmpty(searchText))
+                return true;
+            if (diagnostic.Message.Contains(searchText, StringComparison.OrdinalIgnoreCase))
+                return true;
+            if (diagnostic.File?.Contains(searchText, StringComparison.OrdinalIgnoreCase) ?? false)
+                return true;
+
+            return false;
         }
 
         private Color? GetProblemItemColor(BuildDiagnostic diagnostic)