浏览代码

Merge pull request #90583 from groud/fix_heap-use-after-free_error

Fix heap-use-after-free error in TileMapLayerEditor
Rémi Verschelde 1 年之前
父节点
当前提交
dae51097c5
共有 1 个文件被更改,包括 7 次插入1 次删除
  1. 7 1
      editor/plugins/tiles/tile_map_layer_editor.cpp

+ 7 - 1
editor/plugins/tiles/tile_map_layer_editor.cpp

@@ -3672,10 +3672,16 @@ void TileMapLayerEditor::_node_change(Node *p_node) {
 
 void TileMapLayerEditor::_notification(int p_what) {
 	switch (p_what) {
-		case NOTIFICATION_READY: {
+		case NOTIFICATION_ENTER_TREE: {
 			get_tree()->connect("node_added", callable_mp(this, &TileMapLayerEditor::_node_change));
 			get_tree()->connect("node_removed", callable_mp(this, &TileMapLayerEditor::_node_change));
 		} break;
+
+		case NOTIFICATION_EXIT_TREE: {
+			get_tree()->disconnect("node_added", callable_mp(this, &TileMapLayerEditor::_node_change));
+			get_tree()->disconnect("node_removed", callable_mp(this, &TileMapLayerEditor::_node_change));
+		} break;
+
 		case NOTIFICATION_THEME_CHANGED: {
 			missing_tile_texture = get_editor_theme_icon(SNAME("StatusWarning"));
 			warning_pattern_texture = get_editor_theme_icon(SNAME("WarningPattern"));