Przeglądaj źródła

Fixes the issue where setting global rotation would reset scale.

This was caused because the basis for the target global transform was entirely recreated. This process did not account for the scale of the basis of the current global transform.
This PR amends this by scaling the recreated basis for the global transform by the current global scale of the Node3D.
Note that this scaling has to be done from the current global scale and not from the local scale of the Node3D, otherwise issues would arise if parents of this Node3D would be scaled.
Birk Magnussen 1 rok temu
rodzic
commit
dd97ff44ab
1 zmienionych plików z 1 dodań i 1 usunięć
  1. 1 1
      scene/3d/node_3d.cpp

+ 1 - 1
scene/3d/node_3d.cpp

@@ -293,7 +293,7 @@ Vector3 Node3D::get_global_rotation_degrees() const {
 void Node3D::set_global_rotation(const Vector3 &p_euler_rad) {
 	ERR_THREAD_GUARD;
 	Transform3D transform = get_global_transform();
-	transform.basis = Basis::from_euler(p_euler_rad);
+	transform.basis = Basis::from_euler(p_euler_rad) * Basis::from_scale(transform.basis.get_scale());
 	set_global_transform(transform);
 }