Merge pull request #54366 from lyuma/audio_stream_player_finished_signal

Fix crash due to reentrancy in AudioStreamPlayer* finished signal.

scene/2d/audio_stream_player_2d.cpp

@@ -78,7 +78,6 @@ void AudioStreamPlayer2D::_notification(int p_what) {
 			Vector<Ref<AudioStreamPlayback>> playbacks_to_remove;
 			for (Ref<AudioStreamPlayback> &playback : stream_playbacks) {
 				if (playback.is_valid() && !AudioServer::get_singleton()->is_playback_active(playback) && !AudioServer::get_singleton()->is_playback_paused(playback)) {
-					emit_signal(SNAME("finished"));
 					playbacks_to_remove.push_back(playback);
 				}
 			}
@@ -91,6 +90,9 @@ void AudioStreamPlayer2D::_notification(int p_what) {
 				active.clear();
 				set_physics_process_internal(false);
 			}
+			if (!playbacks_to_remove.is_empty()) {
+				emit_signal(SNAME("finished"));
+			}
 		}
 
 		while (stream_playbacks.size() > max_polyphony) {

scene/3d/audio_stream_player_3d.cpp

@@ -292,7 +292,6 @@ void AudioStreamPlayer3D::_notification(int p_what) {
 			Vector<Ref<AudioStreamPlayback>> playbacks_to_remove;
 			for (Ref<AudioStreamPlayback> &playback : stream_playbacks) {
 				if (playback.is_valid() && !AudioServer::get_singleton()->is_playback_active(playback) && !AudioServer::get_singleton()->is_playback_paused(playback)) {
-					emit_signal(SNAME("finished"));
 					playbacks_to_remove.push_back(playback);
 				}
 			}
@@ -305,6 +304,9 @@ void AudioStreamPlayer3D::_notification(int p_what) {
 				active.clear();
 				set_physics_process_internal(false);
 			}
+			if (!playbacks_to_remove.is_empty()) {
+				emit_signal(SNAME("finished"));
+			}
 		}
 
 		while (stream_playbacks.size() > max_polyphony) {

scene/audio/audio_stream_player.cpp

@@ -45,7 +45,6 @@ void AudioStreamPlayer::_notification(int p_what) {
 		Vector<Ref<AudioStreamPlayback>> playbacks_to_remove;
 		for (Ref<AudioStreamPlayback> &playback : stream_playbacks) {
 			if (playback.is_valid() && !AudioServer::get_singleton()->is_playback_active(playback) && !AudioServer::get_singleton()->is_playback_paused(playback)) {
-				emit_signal(SNAME("finished"));
 				playbacks_to_remove.push_back(playback);
 			}
 		}
@@ -58,6 +57,9 @@ void AudioStreamPlayer::_notification(int p_what) {
 			active.clear();
 			set_process_internal(false);
 		}
+		if (!playbacks_to_remove.is_empty()) {
+			emit_signal(SNAME("finished"));
+		}
 	}
 
 	if (p_what == NOTIFICATION_EXIT_TREE) {