浏览代码

Double check the selected tree item on error activated and error selected callbacks as the value might be nullptr which would cause a crash.

Hristo Stamenov 3 年之前
父节点
当前提交
e0742be4db
共有 1 个文件被更改,包括 9 次插入0 次删除
  1. 9 0
      editor/debugger/script_editor_debugger.cpp

+ 9 - 0
editor/debugger/script_editor_debugger.cpp

@@ -1422,6 +1422,10 @@ bool ScriptEditorDebugger::is_skip_breakpoints() {
 void ScriptEditorDebugger::_error_activated() {
 void ScriptEditorDebugger::_error_activated() {
 	TreeItem *selected = error_tree->get_selected();
 	TreeItem *selected = error_tree->get_selected();
 
 
+	if (!selected) {
+		return;
+	}
+
 	TreeItem *ci = selected->get_first_child();
 	TreeItem *ci = selected->get_first_child();
 	if (ci) {
 	if (ci) {
 		selected->set_collapsed(!selected->is_collapsed());
 		selected->set_collapsed(!selected->is_collapsed());
@@ -1430,6 +1434,11 @@ void ScriptEditorDebugger::_error_activated() {
 
 
 void ScriptEditorDebugger::_error_selected() {
 void ScriptEditorDebugger::_error_selected() {
 	TreeItem *selected = error_tree->get_selected();
 	TreeItem *selected = error_tree->get_selected();
+
+	if (!selected) {
+		return;
+	}
+
 	Array meta = selected->get_metadata(0);
 	Array meta = selected->get_metadata(0);
 	if (meta.size() == 0) {
 	if (meta.size() == 0) {
 		return;
 		return;