浏览代码

Merge pull request #90861 from aaronp64/audio_stream_player_nan

Check for NaN in `set_volume_db` functions
Rémi Verschelde 1 年之前
父节点
当前提交
e34399cdcb
共有 3 个文件被更改,包括 3 次插入0 次删除
  1. 1 0
      scene/2d/audio_stream_player_2d.cpp
  2. 1 0
      scene/3d/audio_stream_player_3d.cpp
  3. 1 0
      scene/audio/audio_stream_player.cpp

+ 1 - 0
scene/2d/audio_stream_player_2d.cpp

@@ -196,6 +196,7 @@ Ref<AudioStream> AudioStreamPlayer2D::get_stream() const {
 }
 
 void AudioStreamPlayer2D::set_volume_db(float p_volume) {
+	ERR_FAIL_COND_MSG(Math::is_nan(p_volume), "Volume can't be set to NaN.");
 	internal->volume_db = p_volume;
 }
 

+ 1 - 0
scene/3d/audio_stream_player_3d.cpp

@@ -496,6 +496,7 @@ Ref<AudioStream> AudioStreamPlayer3D::get_stream() const {
 }
 
 void AudioStreamPlayer3D::set_volume_db(float p_volume) {
+	ERR_FAIL_COND_MSG(Math::is_nan(p_volume), "Volume can't be set to NaN.");
 	internal->volume_db = p_volume;
 }
 

+ 1 - 0
scene/audio/audio_stream_player.cpp

@@ -59,6 +59,7 @@ Ref<AudioStream> AudioStreamPlayer::get_stream() const {
 }
 
 void AudioStreamPlayer::set_volume_db(float p_volume) {
+	ERR_FAIL_COND_MSG(Math::is_nan(p_volume), "Volume can't be set to NaN.");
 	internal->volume_db = p_volume;
 
 	Vector<AudioFrame> volume_vector = _get_volume_vector();