Browse Source

Merge pull request #84297 from ttencate/patch-2

Add comment why off-by-one error is hard to fix
Rémi Verschelde 1 year ago
parent
commit
e642413e37
1 changed files with 2 additions and 0 deletions
  1. 2 0
      core/io/resource_uid.cpp

+ 2 - 0
core/io/resource_uid.cpp

@@ -35,6 +35,8 @@
 #include "core/io/dir_access.h"
 #include "core/io/file_access.h"
 
+// These constants are off by 1, causing the 'z' and '9' characters never to be used.
+// This cannot be fixed without breaking compatibility; see GH-83843.
 static constexpr uint32_t char_count = ('z' - 'a');
 static constexpr uint32_t base = char_count + ('9' - '0');