Browse Source

Fix non const animation node process function

Guilherme Sousa 10 months ago
parent
commit
ec62978dd0

+ 1 - 1
doc/classes/AnimationNode.xml

@@ -63,7 +63,7 @@
 				When inheriting from [AnimationRootNode], implement this virtual method to return whether the [param parameter] is read-only. Parameters are custom local memory used for your animation nodes, given a resource can be reused in multiple trees.
 				When inheriting from [AnimationRootNode], implement this virtual method to return whether the [param parameter] is read-only. Parameters are custom local memory used for your animation nodes, given a resource can be reused in multiple trees.
 			</description>
 			</description>
 		</method>
 		</method>
-		<method name="_process" qualifiers="virtual const" deprecated="Currently this is mostly useless as there is a lack of many APIs to extend AnimationNode by GDScript. It is planned that a more flexible API using structures will be provided in the future.">
+		<method name="_process" qualifiers="virtual" deprecated="Currently this is mostly useless as there is a lack of many APIs to extend AnimationNode by GDScript. It is planned that a more flexible API using structures will be provided in the future.">
 			<return type="float" />
 			<return type="float" />
 			<param index="0" name="time" type="float" />
 			<param index="0" name="time" type="float" />
 			<param index="1" name="seek" type="bool" />
 			<param index="1" name="seek" type="bool" />

+ 7 - 0
misc/extension_api_validation/4.3-stable.expected

@@ -95,3 +95,10 @@ Validate extension JSON: Error: Field 'classes/InputMap/methods/add_action/argum
 
 
 Default deadzone value was changed. No adjustments should be necessary.
 Default deadzone value was changed. No adjustments should be necessary.
 Compatibility method registered.
 Compatibility method registered.
+
+
+GH-97020
+--------
+Validate extension JSON: Error: Field 'classes/AnimationNode/methods/_process': is_const changed value in new API, from true to false.
+
+`_process` virtual method fixed to be non const instead.

+ 1 - 1
scene/animation/animation_tree.h

@@ -151,7 +151,7 @@ protected:
 	GDVIRTUAL1RC(Ref<AnimationNode>, _get_child_by_name, StringName)
 	GDVIRTUAL1RC(Ref<AnimationNode>, _get_child_by_name, StringName)
 	GDVIRTUAL1RC(Variant, _get_parameter_default_value, StringName)
 	GDVIRTUAL1RC(Variant, _get_parameter_default_value, StringName)
 	GDVIRTUAL1RC(bool, _is_parameter_read_only, StringName)
 	GDVIRTUAL1RC(bool, _is_parameter_read_only, StringName)
-	GDVIRTUAL4RC(double, _process, double, bool, bool, bool)
+	GDVIRTUAL4R(double, _process, double, bool, bool, bool)
 	GDVIRTUAL0RC(String, _get_caption)
 	GDVIRTUAL0RC(String, _get_caption)
 	GDVIRTUAL0RC(bool, _has_filter)
 	GDVIRTUAL0RC(bool, _has_filter)