浏览代码

Call Spatial::get_global_transform and Vector3::dot only once within Camera::is_position_behind to avoid redundant work.

(cherry picked from commit b2a204799adb290cd63c9c0346574448336d8f02)
Adam Reichold 5 年之前
父节点
当前提交
f06fc1fdf4
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      scene/3d/camera.cpp

+ 2 - 2
scene/3d/camera.cpp

@@ -333,8 +333,8 @@ Vector3 Camera::project_ray_origin(const Point2 &p_pos) const {
 bool Camera::is_position_behind(const Vector3 &p_pos) const {
 bool Camera::is_position_behind(const Vector3 &p_pos) const {
 
 
 	Transform t = get_global_transform();
 	Transform t = get_global_transform();
-	Vector3 eyedir = -get_global_transform().basis.get_axis(2).normalized();
-	return eyedir.dot(p_pos) < (eyedir.dot(t.origin) + near);
+	Vector3 eyedir = -t.basis.get_axis(2).normalized();
+	return eyedir.dot(p_pos - t.origin) < near;
 }
 }
 
 
 Vector<Vector3> Camera::get_near_plane_points() const {
 Vector<Vector3> Camera::get_near_plane_points() const {