Browse Source

Print a warning when trying to seek in VideoPlayer

Seeking isn't implemented in built-in video formats and can only
be supported in GDNative-provided video formats.

(cherry picked from commit ea46639e22b83ff18d7b85c67b732f6e82ae7df3)
Hugo Locurcio 4 years ago
parent
commit
f0d1bedc74

+ 1 - 0
doc/classes/VideoPlayer.xml

@@ -74,6 +74,7 @@
 		</member>
 		</member>
 		<member name="stream_position" type="float" setter="set_stream_position" getter="get_stream_position">
 		<member name="stream_position" type="float" setter="set_stream_position" getter="get_stream_position">
 			The current position of the stream, in seconds.
 			The current position of the stream, in seconds.
+			[b]Note:[/b] Changing this value won't have any effect as seeking is not implemented yet, except in video formats implemented by a GDNative add-on.
 		</member>
 		</member>
 		<member name="volume" type="float" setter="set_volume" getter="get_volume">
 		<member name="volume" type="float" setter="set_volume" getter="get_volume">
 			Audio volume as a linear value.
 			Audio volume as a linear value.

+ 3 - 4
modules/theora/video_stream_theora.cpp

@@ -617,10 +617,9 @@ float VideoStreamPlaybackTheora::get_playback_position() const {
 	return get_time();
 	return get_time();
 };
 };
 
 
-void VideoStreamPlaybackTheora::seek(float p_time){
-
-	// no
-};
+void VideoStreamPlaybackTheora::seek(float p_time) {
+	WARN_PRINT_ONCE("Seeking in Theora and WebM videos is not implemented yet (it's only supported for GDNative-provided video streams).");
+}
 
 
 void VideoStreamPlaybackTheora::set_mix_callback(AudioMixCallback p_callback, void *p_userdata) {
 void VideoStreamPlaybackTheora::set_mix_callback(AudioMixCallback p_callback, void *p_userdata) {
 
 

+ 1 - 2
modules/webm/video_stream_webm.cpp

@@ -222,8 +222,7 @@ float VideoStreamPlaybackWebm::get_playback_position() const {
 	return video_pos;
 	return video_pos;
 }
 }
 void VideoStreamPlaybackWebm::seek(float p_time) {
 void VideoStreamPlaybackWebm::seek(float p_time) {
-
-	//Not implemented
+	WARN_PRINT_ONCE("Seeking in Theora and WebM videos is not implemented yet (it's only supported for GDNative-provided video streams).");
 }
 }
 
 
 void VideoStreamPlaybackWebm::set_audio_track(int p_idx) {
 void VideoStreamPlaybackWebm::set_audio_track(int p_idx) {