Browse Source

Allow dragging editable children

Haoyu Qiu 1 year ago
parent
commit
f32db73cd2
2 changed files with 19 additions and 8 deletions
  1. 18 7
      editor/scene_tree_editor.cpp
  2. 1 1
      editor/scene_tree_editor.h

+ 18 - 7
editor/scene_tree_editor.cpp

@@ -40,7 +40,7 @@
 #include "scene/main/viewport.h"
 #include "scene/main/viewport.h"
 #include "scene/resources/packed_scene.h"
 #include "scene/resources/packed_scene.h"
 
 
-Node *SceneTreeEditor::get_scene_node() {
+Node *SceneTreeEditor::get_scene_node() const {
 	ERR_FAIL_COND_V(!is_inside_tree(), nullptr);
 	ERR_FAIL_COND_V(!is_inside_tree(), nullptr);
 
 
 	return get_tree()->get_edited_scene_root();
 	return get_tree()->get_edited_scene_root();
@@ -995,11 +995,8 @@ Variant SceneTreeEditor::get_drag_data_fw(const Point2 &p_point, Control *p_from
 
 
 		Node *n = get_node(np);
 		Node *n = get_node(np);
 		if (n) {
 		if (n) {
-			// Only allow selection if not part of an instanced scene.
-			if (!n->get_owner() || n->get_owner() == get_scene_node() || n->get_owner()->get_filename() == String()) {
-				selected.push_back(n);
-				icons.push_back(next->get_icon(0));
-			}
+			selected.push_back(n);
+			icons.push_back(next->get_icon(0));
 		}
 		}
 		next = tree->get_next_selected(next);
 		next = tree->get_next_selected(next);
 	}
 	}
@@ -1110,7 +1107,21 @@ bool SceneTreeEditor::can_drop_data_fw(const Point2 &p_point, const Variant &p_d
 		}
 		}
 	}
 	}
 
 
-	return String(d["type"]) == "nodes" && filter == String();
+	if (filter.empty() && String(d["type"]) == "nodes") {
+		Array nodes = d["nodes"];
+
+		for (int i = 0; i < nodes.size(); i++) {
+			Node *n = get_node(nodes[i]);
+			// Only allow selection if not part of an instanced scene.
+			if (n && n->get_owner() && n->get_owner() != get_scene_node() && !n->get_owner()->get_filename().empty()) {
+				return false;
+			}
+		}
+
+		return true;
+	}
+
+	return false;
 }
 }
 void SceneTreeEditor::drop_data_fw(const Point2 &p_point, const Variant &p_data, Control *p_from) {
 void SceneTreeEditor::drop_data_fw(const Point2 &p_point, const Variant &p_data, Control *p_from) {
 	if (!can_drop_data_fw(p_point, p_data, p_from)) {
 	if (!can_drop_data_fw(p_point, p_data, p_from)) {

+ 1 - 1
editor/scene_tree_editor.h

@@ -114,7 +114,7 @@ class SceneTreeEditor : public Control {
 	void _update_visibility_color(Node *p_node, TreeItem *p_item);
 	void _update_visibility_color(Node *p_node, TreeItem *p_item);
 
 
 	void _selection_changed();
 	void _selection_changed();
-	Node *get_scene_node();
+	Node *get_scene_node() const;
 
 
 	Variant get_drag_data_fw(const Point2 &p_point, Control *p_from);
 	Variant get_drag_data_fw(const Point2 &p_point, Control *p_from);
 	bool can_drop_data_fw(const Point2 &p_point, const Variant &p_data, Control *p_from) const;
 	bool can_drop_data_fw(const Point2 &p_point, const Variant &p_data, Control *p_from) const;