ソースを参照

Merge pull request #58596 from rburing/joints_disconnect_connected_signals

`Joint2D` and `Joint3D`: disconnect only connected signals
Rémi Verschelde 3 年 前
コミット
f968c11b86
2 ファイル変更6 行追加6 行削除
  1. 3 3
      scene/2d/joint_2d.cpp
  2. 3 3
      scene/3d/joint_3d.cpp

+ 3 - 3
scene/2d/joint_2d.cpp

@@ -128,7 +128,7 @@ void Joint2D::set_node_a(const NodePath &p_node_a) {
 		return;
 	}
 
-	if (joint.is_valid()) {
+	if (is_configured()) {
 		_disconnect_signals();
 	}
 
@@ -145,7 +145,7 @@ void Joint2D::set_node_b(const NodePath &p_node_b) {
 		return;
 	}
 
-	if (joint.is_valid()) {
+	if (is_configured()) {
 		_disconnect_signals();
 	}
 
@@ -164,7 +164,7 @@ void Joint2D::_notification(int p_what) {
 		} break;
 
 		case NOTIFICATION_EXIT_TREE: {
-			if (joint.is_valid()) {
+			if (is_configured()) {
 				_disconnect_signals();
 				_update_joint(true);
 			}

+ 3 - 3
scene/3d/joint_3d.cpp

@@ -124,7 +124,7 @@ void Joint3D::set_node_a(const NodePath &p_node_a) {
 		return;
 	}
 
-	if (joint.is_valid()) {
+	if (is_configured()) {
 		_disconnect_signals();
 	}
 
@@ -141,7 +141,7 @@ void Joint3D::set_node_b(const NodePath &p_node_b) {
 		return;
 	}
 
-	if (joint.is_valid()) {
+	if (is_configured()) {
 		_disconnect_signals();
 	}
 
@@ -171,7 +171,7 @@ void Joint3D::_notification(int p_what) {
 		} break;
 
 		case NOTIFICATION_EXIT_TREE: {
-			if (joint.is_valid()) {
+			if (is_configured()) {
 				_disconnect_signals();
 				_update_joint(true);
 			}