Browse Source

Merge pull request #1539 from Azaezel/alpha41/compareContrast

correct DECLARE_<foo>ASSET assigns
Brian Roberts 2 weeks ago
parent
commit
0dbfa4a601

+ 4 - 4
Engine/source/T3D/assets/ImageAsset.h

@@ -243,7 +243,7 @@ public:
          return;                                                                                                                                                              \
       if(get##name##File() == _in)                                                                                                                                            \
          return;                                                                                                                                                              \
-      if(_in == NULL || _in == StringTable->EmptyString() || _in == "")                                                                                                       \
+      if(_in == NULL || !String::compare(_in,StringTable->EmptyString()))                                                                                                     \
       {                                                                                                                                                                       \
          m##name##Asset = NULL;                                                                                                                                               \
          m##name##File = "";                                                                                                                                                  \
@@ -300,7 +300,7 @@ public:
          return;                                                                                                                                                              \
       if(get##name##File() == _in)                                                                                                                                            \
          return;                                                                                                                                                              \
-      if(_in == NULL || _in == StringTable->EmptyString() || _in == "")                                                                                                       \
+      if(_in == NULL || !String::compare(_in,StringTable->EmptyString()))                                                                                                       \
       {                                                                                                                                                                       \
          m##name##Asset = NULL;                                                                                                                                               \
          m##name##File = "";                                                                                                                                                  \
@@ -364,7 +364,7 @@ public:
          return;                                                                                                                                                              \
       if(get##name##File(index) == _in)                                                                                                                                       \
          return;                                                                                                                                                              \
-      if(_in == NULL || _in == StringTable->EmptyString() || _in == "")                                                                                                       \
+      if(_in == NULL || !String::compare(_in,StringTable->EmptyString()))                                                                                                       \
       {                                                                                                                                                                       \
          m##name##Asset[index] = NULL;                                                                                                                                        \
          m##name##File[index] = "";                                                                                                                                           \
@@ -422,7 +422,7 @@ public:
          return;                                                                                                                                                              \
       if(get##name##File(index) == _in)                                                                                                                                       \
          return;                                                                                                                                                              \
-      if(_in == NULL || _in == StringTable->EmptyString() || _in == "")                                                                                                       \
+      if(_in == NULL || !String::compare(_in,StringTable->EmptyString()))                                                                                                       \
       {                                                                                                                                                                       \
          m##name##Asset[index] = NULL;                                                                                                                                        \
          m##name##File[index] = "";                                                                                                                                           \

+ 1 - 1
Engine/source/T3D/assets/LevelAsset.h

@@ -197,7 +197,7 @@ public: \
          {\
             m##name##Asset->getChangedSignal().remove(this, &className::changeFunc);\
          }\
-         if (_in == NULL || _in == StringTable->EmptyString())\
+         if (_in == NULL || !String::compare(_in,StringTable->EmptyString()))\
          {\
             m##name##AssetId = StringTable->EmptyString();\
             m##name##Asset = NULL;\

+ 4 - 4
Engine/source/T3D/assets/ShapeAsset.h

@@ -254,7 +254,7 @@ public:
          return;                                                                                                                                                              \
       if(get##name##File() == _in)                                                                                                                                            \
          return;                                                                                                                                                              \
-      if(_in == NULL || _in == StringTable->EmptyString() || _in == "")                                                                                                       \
+      if(_in == NULL || !String::compare(_in,StringTable->EmptyString()))                                                                                                       \
       {                                                                                                                                                                       \
          m##name##Asset = NULL;                                                                                                                                               \
          m##name##File = "";                                                                                                                                                  \
@@ -310,7 +310,7 @@ public:
          return;                                                                                                                                                              \
       if(get##name##File() == _in)                                                                                                                                            \
          return;                                                                                                                                                              \
-      if(_in == NULL || _in == StringTable->EmptyString() || _in == "")                                                                                                       \
+      if(_in == NULL || !String::compare(_in,StringTable->EmptyString()))                                                                                                       \
       {                                                                                                                                                                       \
          m##name##Asset = NULL;                                                                                                                                               \
          m##name##File = "";                                                                                                                                                  \
@@ -373,7 +373,7 @@ public:
          return;                                                                                                                                                              \
       if(get##name##File(index) == _in)                                                                                                                                       \
          return;                                                                                                                                                              \
-      if(_in == NULL || _in == StringTable->EmptyString() || _in == "")                                                                                                       \
+      if(_in == NULL || !String::compare(_in,StringTable->EmptyString()))                                                                                                       \
       {                                                                                                                                                                       \
          m##name##Asset[index] = NULL;                                                                                                                                        \
          m##name##File[index] = "";                                                                                                                                           \
@@ -429,7 +429,7 @@ public:
          return;                                                                                                                                                              \
       if(get##name##File(index) == _in)                                                                                                                                       \
          return;                                                                                                                                                              \
-      if (_in == NULL || _in == StringTable->EmptyString())                                                                                                                   \
+      if (_in == NULL || !String::compare(_in,StringTable->EmptyString()))                                                                                                                   \
       {                                                                                                                                                                       \
          m##name##Asset[index] = NULL;                                                                                                                                        \
          m##name##File[index] = "";                                                                                                                                           \

+ 2 - 2
Engine/source/T3D/assets/SoundAsset.h

@@ -205,7 +205,7 @@ public: \
    {\
       if(m##name##AssetId != _in || m##name##Name != _in)\
       {\
-         if (_in == NULL || _in == StringTable->EmptyString())\
+         if (_in == NULL || !String::compare(_in,StringTable->EmptyString()))\
          {\
             m##name##Name = StringTable->EmptyString();\
             m##name##AssetId = StringTable->EmptyString();\
@@ -394,7 +394,7 @@ public: \
       {\
          if(index >= sm##name##Count || index < 0) \
                return false;\
-         if (_in == NULL || _in == StringTable->EmptyString())\
+         if (_in == NULL || !String::compare(_in,StringTable->EmptyString()))\
          {\
             m##name##Name[index] = StringTable->EmptyString();\
             m##name##AssetId[index] = StringTable->EmptyString();\

+ 1 - 1
Engine/source/T3D/assets/SubSceneAsset.h

@@ -79,7 +79,7 @@ public: \
          {\
             m##name##Asset->getChangedSignal().remove(this, &className::changeFunc);\
          }\
-         if (_in == NULL || _in == StringTable->EmptyString())\
+         if (_in == NULL || !String::compare(_in,StringTable->EmptyString()))\
          {\
             m##name##AssetId = StringTable->EmptyString();\
             m##name##Asset = NULL;\