Преглед изворни кода

Fix member vars left uninitialized in constructors

Ben Payne пре 10 година
родитељ
комит
0ffd7f5620

+ 1 - 0
Engine/source/T3D/fps/guiClockHud.cpp

@@ -87,6 +87,7 @@ ConsoleDocClass( GuiClockHud,
 GuiClockHud::GuiClockHud()
 {
    mShowFrame = mShowFill = true;
+   mTimeReversed = false;
    mFillColor.set(0, 0, 0, 0.5);
    mFrameColor.set(0, 1, 0, 1);
    mTextColor.set( 0, 1, 0, 1 );

+ 3 - 0
Engine/source/T3D/fps/guiShapeNameHud.cpp

@@ -117,8 +117,11 @@ GuiShapeNameHud::GuiShapeNameHud()
 {
    mFillColor.set( 0.25f, 0.25f, 0.25f, 0.25f );
    mFrameColor.set( 0, 1, 0, 1 );
+   mLabelFillColor.set( 0.25f, 0.25f, 0.25f, 0.25f );
+   mLabelFrameColor.set( 0, 1, 0, 1 );
    mTextColor.set( 0, 1, 0, 1 );
    mShowFrame = mShowFill = true;
+   mShowLabelFrame = mShowLabelFill = false;
    mVerticalOffset = 0.5f;
    mDistanceFade = 0.1f;
    mLabelPadding.set(0, 0);

+ 1 - 1
Engine/source/T3D/fx/groundCover.cpp

@@ -148,7 +148,7 @@ protected:
 
 public:
 
-   GroundCoverCell() {}
+   GroundCoverCell() : mDirty(false) {}
 
    ~GroundCoverCell() 
    {

+ 1 - 0
Engine/source/T3D/fx/lightning.cpp

@@ -156,6 +156,7 @@ LightningStrikeEvent::LightningStrikeEvent()
 {
    mLightning = NULL;
    mTarget = NULL;
+   mClientId = 0;
 }
 
 LightningStrikeEvent::~LightningStrikeEvent()

+ 1 - 0
Engine/source/app/net/serverQuery.cpp

@@ -240,6 +240,7 @@ struct ServerFilter
 
    ServerFilter()
    {
+      type = Normal;
       queryFlags = 0;
       gameType = NULL;
       missionType = NULL;

+ 1 - 1
Engine/source/core/util/test/strTest.cpp

@@ -39,7 +39,7 @@ protected:
       const UTF16* mUTF16;
       U32 mLength;
 
-      StrTest() : mData( 0 ), mUTF16( 0 ) {}
+      StrTest() : mData( 0 ), mUTF16( 0 ), mLength( 0 ) {}
       StrTest( const char* str )
          : mData( str ), mLength( str ? dStrlen( str ) : 0 ), mUTF16( NULL )
       {

+ 6 - 0
Engine/source/environment/basicClouds.cpp

@@ -63,6 +63,12 @@ BasicClouds::BasicClouds()
    mTypeMask |= EnvironmentObjectType | StaticObjectType;
    mNetFlags.set(Ghostable | ScopeAlways);
 
+   mTimeSC =
+   mModelViewProjSC =
+   mTexScaleSC =
+   mTexDirectionSC =
+   mTexOffsetSC = 0;
+
    mLayerEnabled[0] = true;
    mLayerEnabled[1] = true;
    mLayerEnabled[2] = true;

+ 16 - 4
Engine/source/environment/cloudLayer.cpp

@@ -73,15 +73,27 @@ U32 CloudLayer::smVertCount = smVertStride * smVertStride;
 U32 CloudLayer::smTriangleCount = smStrideMinusOne * smStrideMinusOne * 2;
 
 CloudLayer::CloudLayer()
-: mBaseColor( 0.9f, 0.9f, 0.9f, 1.0f ),
-  mCoverage( 0.5f ),
+: mLastTime( 0 ),
+  mBaseColor( 0.9f, 0.9f, 0.9f, 1.0f ),
   mExposure( 1.0f ),
-  mWindSpeed( 1.0f ),
-  mLastTime( 0 )
+  mCoverage( 0.5f ),
+  mWindSpeed( 1.0f )
 {
    mTypeMask |= EnvironmentObjectType | StaticObjectType;
    mNetFlags.set(Ghostable | ScopeAlways);
 
+   mModelViewProjSC =
+   mAmbientColorSC =
+   mSunColorSC =
+   mSunVecSC =
+   mTexScaleSC =
+   mBaseColorSC =
+   mCoverageSC =
+   mExposureSC =
+   mEyePosWorldSC = 0;
+
+   mTexOffsetSC[0] = mTexOffsetSC[1] = mTexOffsetSC[2] = 0;
+
    mTexScale[0] = 1.0;
    mTexScale[1] = 1.0;
    mTexScale[2] = 1.0;

+ 1 - 1
Engine/source/gfx/gl/gfxGLShader.cpp

@@ -64,7 +64,7 @@ public:
 };
 
 GFXGLShaderConstHandle::GFXGLShaderConstHandle( GFXGLShader *shader )
- : mShader( shader ), mSamplerNum(-1), mInstancingConstant(false)
+ : mShader( shader ), mLocation(0), mOffset(0), mSize(0), mSamplerNum(-1), mInstancingConstant(false)
 {
    mValid = false;
 }

+ 1 - 1
Engine/source/gfx/video/theoraTexture.h

@@ -103,7 +103,7 @@ class TheoraTextureFrame
       F32 mFrameDuration;
       
       TheoraTextureFrame()
-         : mLockedRect( NULL )
+         : mLockedRect( NULL ), mFrameNumber(0), mFrameTime(0.0f), mFrameDuration(0.0f)
       {
       }
 };

+ 1 - 1
Engine/source/gfx/video/videoEncoderTheora.cpp

@@ -193,7 +193,7 @@ class VideoEncoderTheora : public VideoEncoder, public Thread
    
 public:
    VideoEncoderTheora() :
-      mLastFrame(NULL)      
+      mCurrentFrame(0), td(NULL), mLastFrame(NULL)
    {
       setStatus(false);      
    }

+ 1 - 1
Engine/source/gui/controls/guiGameListOptionsCtrl.h

@@ -41,7 +41,7 @@ protected:
       S32                        mSelectedOption;  ///< Index into mOptions pointing at the selected option
       bool                       mWrapOptions;     ///< Determines if options should "wrap around" at the ends
 
-      Row()
+      Row() : mSelectedOption(0), mWrapOptions(false)
       {
          VECTOR_SET_ASSOCIATION( mOptions );
       }

+ 4 - 4
Engine/source/gui/worldEditor/guiDecalEditorCtrl.cpp

@@ -905,7 +905,7 @@ ConsoleDocClass( DICreateUndoAction,
 				"@internal");
 
 DICreateUndoAction::DICreateUndoAction( const UTF8* actionName )
-   :  UndoAction( actionName )
+   :  UndoAction( actionName ), mEditor(0), mDatablockId(0)
 {
 }
 
@@ -993,7 +993,7 @@ ConsoleDocClass( DIDeleteUndoAction,
 				"@internal");
 
 DIDeleteUndoAction::DIDeleteUndoAction( const UTF8 *actionName )
-   :  UndoAction( actionName )
+   :  UndoAction( actionName ), mEditor(0), mDatablockId(0)
 {
 }
 
@@ -1081,7 +1081,7 @@ ConsoleDocClass( DBDeleteUndoAction,
 				"@internal");
 
 DBDeleteUndoAction::DBDeleteUndoAction( const UTF8 *actionName )
-   :  UndoAction( actionName )
+   :  UndoAction( actionName ), mEditor(0), mDatablockId(0)
 {
 }
 
@@ -1190,7 +1190,7 @@ ConsoleDocClass( DBRetargetUndoAction,
 				"@internal");
 
 DBRetargetUndoAction::DBRetargetUndoAction( const UTF8 *actionName )
-   :  UndoAction( actionName )
+   :  UndoAction( actionName ), mEditor(0), mDBFromId(0), mDBToId(0)
 {
 }
 

+ 3 - 1
Engine/source/lighting/basic/blTerrainSystem.cpp

@@ -159,7 +159,9 @@ blTerrainProxy::blTerrainProxy( SceneObject *obj ) :
    Parent( obj ),
    mLightMapSize( getObject()->getLightMapSize() ),
    mTerrainBlockSize( getObject()->getBlockSize() ),
-   mLightmap( NULL )
+   mShadowVolume( NULL ),
+   mLightmap( NULL ),
+   sgBakedLightmap( NULL )
 {
 }
 

+ 5 - 1
Engine/source/navigation/duDebugDrawTorque.cpp

@@ -38,9 +38,13 @@
 
 duDebugDrawTorque::duDebugDrawTorque()
 {
+   mPrimType = 0;
+   mQuadsMode = false;
+   mVertCount = 0;
+   mGroup = 0;
+   mCurrColor = 0;
    mOverrideColor = 0;
    mOverride = false;
-   mGroup = 0;
 }
 
 duDebugDrawTorque::~duDebugDrawTorque()

+ 1 - 0
Engine/source/navigation/recastPolyList.cpp

@@ -36,6 +36,7 @@ RecastPolyList::RecastPolyList()
    ntris = 0;
    tris = NULL;
    tricap = 0;
+   vidx = 0;
 }
 
 RecastPolyList::~RecastPolyList()

+ 1 - 0
Engine/source/platformWin32/threads/thread.cpp

@@ -53,6 +53,7 @@ public:
       mRunArg     = 0;
       mThread     = 0;
       mThreadHnd  = 0;
+      mThreadID   = 0;
       mDead       = false;
    };
 };

+ 4 - 0
Engine/source/platformWin32/winTimer.cpp

@@ -43,13 +43,17 @@ public:
    Win32Timer()
    {
       mPerfCountRemainderCurrent = 0.0f;
+      mPerfCountRemainderNext = 0.0f;
 
       // Attempt to use QPC for high res timing, otherwise fallback to GTC.
       mUsingPerfCounter = QueryPerformanceFrequency((LARGE_INTEGER *) &mFrequency);
       if(mUsingPerfCounter)
          mUsingPerfCounter = QueryPerformanceCounter((LARGE_INTEGER *) &mPerfCountCurrent);
       if(!mUsingPerfCounter)
+      {
          mTickCountCurrent = GetTickCount();
+         mTickCountNext = 0;
+      }
    }
 
    const S32 getElapsedMs()

+ 3 - 0
Engine/source/platformX86UNIX/x86UNIXInput.client.cpp

@@ -364,6 +364,9 @@ bool Platform::setClipboard(const char *text)
 XClipboard::XClipboard()
 {
    mInitialized = false;
+   mXData = 0;
+   mTData = 0;
+   mTDataSize = 0;
 }
 
 //------------------------------------------------------------------------------

+ 1 - 1
Engine/source/scene/pathManager.cpp

@@ -86,7 +86,7 @@ class PathManagerEvent : public NetEvent
 
   public:
    typedef NetEvent Parent;
-   PathManagerEvent() { }
+   PathManagerEvent() : modifiedPath(0), clearPaths(false) { }
 
    void pack(NetConnection*, BitStream*);
    void write(NetConnection*, BitStream*);

+ 5 - 2
Engine/source/shaderGen/langElement.cpp

@@ -89,19 +89,22 @@ Var::Var()
 {
    dStrcpy( (char*)type, "float4" );
    structName[0] = '\0';
+   connectName[0] = '\0';
+   constSortPos = cspUninit;
+   constNum = 0;
+   texCoordNum = 0;
    uniform = false;
    vertData = false;
    connector = false;
    sampler = false;
    mapsToSampler = false;
-   texCoordNum = 0;
-   constSortPos = cspUninit;
    arraySize = 1;
 }
 
 Var::Var( const char *inName, const char *inType )
 {
    structName[0] = '\0';
+   connectName[0] = '\0';
    uniform = false;
    vertData = false;
    connector = false;

+ 1 - 0
Engine/source/shaderGen/shaderComp.cpp

@@ -31,6 +31,7 @@
 ShaderConnector::ShaderConnector()
 {
    mCurTexElem = 0;
+   mName[0] = '\0';
 }
 
 //----------------------------------------------------------------------------

+ 6 - 0
Engine/source/sim/netGhost.cpp

@@ -52,7 +52,13 @@ public:
          objectId = obj->getId();
          ghostIndex = index;
       }
+      else
+      {
+         objectId = 0;
+         ghostIndex = 0;
+      }
       object = NULL;
+      validObject = false;
    }
    ~GhostAlwaysObjectEvent()
       { delete object; }