瀏覽代碼

Merge pull request #833 from just-bank/fix-derefptr

Fix: Null'ed pointer usage, possible access violation.
Daniel Buckmaster 11 年之前
父節點
當前提交
1554ea6faf
共有 3 個文件被更改,包括 3 次插入14 次删除
  1. 1 5
      Engine/source/T3D/debris.cpp
  2. 1 4
      Engine/source/T3D/fx/explosion.cpp
  3. 1 5
      Engine/source/T3D/fx/splash.cpp

+ 1 - 5
Engine/source/T3D/debris.cpp

@@ -659,11 +659,7 @@ void Debris::onRemove()
       }
    }
 
-   if( getSceneManager() )
-      getSceneManager()->removeObjectFromScene(this);
-
-   if( getContainer() )
-      getContainer()->removeObject(this);
+   removeFromScene();
 
    Parent::onRemove();
 }

+ 1 - 4
Engine/source/T3D/fx/explosion.cpp

@@ -964,10 +964,7 @@ void Explosion::onRemove()
       mMainEmitter = NULL;
    }
 
-   if (getSceneManager() != NULL)
-      getSceneManager()->removeObjectFromScene(this);
-   if (getContainer() != NULL)
-      getContainer()->removeObject(this);
+   removeFromScene();
 
    Parent::onRemove();
 }

+ 1 - 5
Engine/source/T3D/fx/splash.cpp

@@ -415,11 +415,7 @@ void Splash::onRemove()
 
    ringList.clear();
 
-   if( getSceneManager() )
-      getSceneManager()->removeObjectFromScene(this);
-
-   if( getContainer() )
-      getContainer()->removeObject(this);
+   removeFromScene();
 
    Parent::onRemove();
 }