Browse Source

Fix: dSprintf should receive size of the buffer, not the size of the pointer.

It was safe, as we are using static console return buffer,
which is large enough to hold enough data (default is 2048).
bank 11 years ago
parent
commit
68b12981ae
2 changed files with 2 additions and 2 deletions
  1. 1 1
      Engine/source/T3D/missionArea.cpp
  2. 1 1
      Engine/source/gui/editor/guiDebugger.cpp

+ 1 - 1
Engine/source/T3D/missionArea.cpp

@@ -179,7 +179,7 @@ DefineEngineMethod( MissionArea, getArea, const char *, (),,
    char* returnBuffer = Con::getReturnBuffer(48);
    char* returnBuffer = Con::getReturnBuffer(48);
 
 
    RectI area = object->getArea();
    RectI area = object->getArea();
-   dSprintf(returnBuffer, sizeof(returnBuffer), "%d %d %d %d", area.point.x, area.point.y, area.extent.x, area.extent.y);
+   dSprintf(returnBuffer, 48, "%d %d %d %d", area.point.x, area.point.y, area.extent.x, area.extent.y);
    return(returnBuffer);
    return(returnBuffer);
 }
 }
 
 

+ 1 - 1
Engine/source/gui/editor/guiDebugger.cpp

@@ -79,7 +79,7 @@ ConsoleMethod(DbgFileView, getCurrentLine, const char *, 2, 2, "()"
 	S32 lineNum;
 	S32 lineNum;
    const char *file = object->getCurrentLine(lineNum);
    const char *file = object->getCurrentLine(lineNum);
    char* ret = Con::getReturnBuffer(256);
    char* ret = Con::getReturnBuffer(256);
-	dSprintf(ret, sizeof(ret), "%s\t%d", file, lineNum);
+	dSprintf(ret, 256, "%s\t%d", file, lineNum);
 	return ret;
 	return ret;
 }
 }