Browse Source

Actual buffer overflow bug found because of these fixes

Glenn Smith 7 years ago
parent
commit
e03a86f75a
1 changed files with 2 additions and 2 deletions
  1. 2 2
      Engine/source/console/fileSystemFunctions.cpp

+ 2 - 2
Engine/source/console/fileSystemFunctions.cpp

@@ -643,8 +643,8 @@ DefineEngineFunction(fileName, String, ( const char* fileName ),,
       name = szPathCopy;
    else
       name++;
-   char *ret = Con::getReturnBuffer(dStrlen(name));
-   dStrcpy(ret, name, dStrlen(name));
+   char *ret = Con::getReturnBuffer(dStrlen(name) + 1);
+   dStrcpy(ret, name, dStrlen(name) + 1);
    return ret;
 }