Merge pull request #1713 from Azaezel/c4189_cleanup

adresses C4189 warnings

Engine/source/core/ogg/oggTheoraDecoder.cpp

@@ -420,7 +420,7 @@ void OggTheoraDecoder::_transcode( th_ycbcr_buffer ycbcr, U8* buffer, const U32
 }
 
 //-----------------------------------------------------------------------------
-
+#if defined( TORQUE_CPU_X86 )
 void OggTheoraDecoder::_transcode420toRGBA_SSE2( th_ycbcr_buffer ycbcr, U8* buffer, U32 width, U32 height, U32 pitch )
 {
    AssertFatal( width % 2 == 0, "OggTheoraDecoder::_transcode420toRGBA_SSE2() - width must be multiple of 2" );
@@ -692,3 +692,4 @@ void OggTheoraDecoder::_transcode420toRGBA_SSE2( th_ycbcr_buffer ycbcr, U8* buff
    
    #endif
 }
+#endif

Engine/source/core/ogg/oggTheoraDecoder.h

@@ -172,10 +172,10 @@ class OggTheoraDecoder : public OggDecoder,
       /// Generic transcoder going from any of the Y'CbCr pixel formats to
       /// any RGB format (that is supported by GFXFormatUtils).
       void _transcode( th_ycbcr_buffer ycbcr, U8* buffer, U32 width, U32 height );
-      
-      /// Transcoder with fixed 4:2:0 to RGBA conversion using SSE2 assembly.
+#if defined( TORQUE_CPU_X86 )
+      /// Transcoder with fixed 4:2:0 to RGBA conversion using SSE2 assembly. Unused on 64 bit archetecture.
       void _transcode420toRGBA_SSE2( th_ycbcr_buffer ycbcr, U8* buffer, U32 width, U32 height, U32 pitch );
-      
+#endif
       // OggDecoder.
       virtual bool _detect( ogg_page* startPage );
       virtual bool _init();

Engine/source/shaderGen/GLSL/shaderFeatureGLSL.cpp

@@ -2795,18 +2795,4 @@ void ImposterVertFeatureGLSL::determineFeature( Material *material,
 {      
    if ( features.hasFeature( MFT_ImposterVert ) )
       outFeatureData->features.addFeature( MFT_ImposterVert );
-}
-
-//****************************************************************************
-// Vertex position
-//****************************************************************************
-void DeferredSkyGLSL::processVert( Vector<ShaderComponent*> &componentList, 
-                                    const MaterialFeatureData &fd )
-{
-   Var *outPosition = (Var*)LangElement::find( "gl_Position" );
-   MultiLine *meta = new MultiLine;
-   //meta->addStatement( new GenOp( "   @.w = @.z;\r\n", outPosition, outPosition ) );
-
-   output = meta;
-}
-
+}

Engine/source/shaderGen/GLSL/shaderFeatureGLSL.h

@@ -659,12 +659,4 @@ public:
 											MaterialFeatureData *outFeatureData );
 };
 
-
-class DeferredSkyGLSL : public ShaderFeatureGLSL
-{
-public:
-   virtual String getName() { return "Deferred Shading: Sky"; }
-   virtual void processVert( Vector<ShaderComponent*> &componentList,
-                             const MaterialFeatureData &fd );
-};
 #endif // _SHADERGEN_GLSL_SHADERFEATUREGLSL_H_

Engine/source/shaderGen/GLSL/shaderGenGLSLInit.cpp

@@ -104,7 +104,7 @@ void _initShaderGenGLSL( ShaderGen *shaderGen )
    FEATUREMGR->registerFeature( MFT_DeferredSpecVars, new DeferredSpecVarsGLSL );
    FEATUREMGR->registerFeature( MFT_DeferredMatInfoFlags, new DeferredMatInfoFlagsGLSL );
    FEATUREMGR->registerFeature( MFT_DeferredEmptySpec, new DeferredEmptySpecGLSL );
-   FEATUREMGR->registerFeature( MFT_SkyBox, new DeferredSkyGLSL );
+   FEATUREMGR->registerFeature( MFT_SkyBox, new NamedFeatureGLSL( "skybox" ) );
 }
 
 MODULE_BEGIN( ShaderGenGLSL )

Engine/source/shaderGen/HLSL/shaderFeatureHLSL.cpp

@@ -2991,16 +2991,3 @@ void ImposterVertFeatureHLSL::determineFeature( Material *material,
       outFeatureData->features.addFeature( MFT_ImposterVert );
 }
 
-
-//****************************************************************************
-// Vertex position
-//****************************************************************************
-void DeferredSkyHLSL::processVert( Vector<ShaderComponent*> &componentList, 
-                                    const MaterialFeatureData &fd )
-{
-   Var *outPosition = (Var*)LangElement::find( "hpos" );
-   MultiLine *meta = new MultiLine;
-   //meta->addStatement( new GenOp( "   @.w = @.z;\r\n", outPosition, outPosition ) );
-
-   output = meta;
-}

Engine/source/shaderGen/HLSL/shaderFeatureHLSL.h

@@ -663,13 +663,4 @@ public:
                                   MaterialFeatureData *outFeatureData );
 };
 
-
-class DeferredSkyHLSL : public ShaderFeatureHLSL
-{
-public:
-   virtual String getName() { return "Deferred Shading: Sky"; }
-   virtual void processVert( Vector<ShaderComponent*> &componentList,
-                             const MaterialFeatureData &fd );
-};
-
 #endif // _SHADERGEN_HLSL_SHADERFEATUREHLSL_H_

Engine/source/shaderGen/HLSL/shaderGenHLSLInit.cpp

@@ -106,7 +106,7 @@ void _initShaderGenHLSL( ShaderGen *shaderGen )
    FEATUREMGR->registerFeature( MFT_DeferredSpecVars, new DeferredSpecVarsHLSL );
    FEATUREMGR->registerFeature( MFT_DeferredMatInfoFlags, new DeferredMatInfoFlagsHLSL );
    FEATUREMGR->registerFeature( MFT_DeferredEmptySpec, new DeferredEmptySpecHLSL );
-   FEATUREMGR->registerFeature( MFT_SkyBox, new DeferredSkyHLSL );
+   FEATUREMGR->registerFeature( MFT_SkyBox,  new NamedFeatureHLSL( "skybox" ) );
 }
 
 MODULE_BEGIN( ShaderGenHLSL )