Browse Source

[unity] Fixed warnings/messages reported by Microsoft's Analyzers for Unity. Closes #1753.

Harald Csaszar 5 năm trước cách đây
mục cha
commit
977133fc38

+ 1 - 1
spine-unity/Assets/Spine Examples/Scripts/FootSoldierExample.cs

@@ -70,7 +70,7 @@ namespace Spine.Unity.Examples {
 		}
 
 		void Apply (SkeletonRenderer skeletonRenderer) {
-			StartCoroutine("Blink");
+			StartCoroutine(Blink());
 		}
 
 		void Update () {

+ 1 - 1
spine-unity/Assets/Spine/Editor/spine-unity/Editor/Asset Types/SpineAtlasAssetInspector.cs

@@ -108,7 +108,7 @@ namespace Spine.Unity.Editor {
 			}
 
 			serializedObject.Update();
-			atlasAsset = atlasAsset ?? (SpineAtlasAsset)target;
+			atlasAsset = (atlasAsset == null) ? (SpineAtlasAsset)target : atlasAsset;
 			EditorGUI.BeginChangeCheck();
 			EditorGUILayout.PropertyField(atlasFile);
 			EditorGUILayout.PropertyField(materials, true);

+ 1 - 1
spine-unity/Assets/Spine/Editor/spine-unity/Editor/Asset Types/SpineSpriteAtlasAssetInspector.cs

@@ -71,7 +71,7 @@ namespace Spine.Unity.Editor {
 			}
 
 			serializedObject.Update();
-			atlasAsset = atlasAsset ?? (SpineSpriteAtlasAsset)target;
+			atlasAsset = (atlasAsset == null) ? (SpineSpriteAtlasAsset)target : atlasAsset;
 
 			if (atlasAsset.RegionsNeedLoading) {
 				if (GUILayout.Button(SpineInspectorUtility.TempContent("Load regions by entering Play mode"), GUILayout.Height(20))) {

+ 1 - 1
spine-unity/Assets/Spine/Editor/spine-unity/Editor/Windows/SkeletonBaker.cs

@@ -621,7 +621,7 @@ namespace Spine.Unity.Editor {
 			int[] triangles = attachment.Triangles;
 			Color color = new Color(attachment.R, attachment.G, attachment.B, attachment.A);
 
-			mesh = mesh ?? new Mesh();
+			mesh = (mesh == null) ? new Mesh() : mesh;
 
 			mesh.triangles = new int[0];
 

+ 2 - 0
spine-unity/Modules/com.esotericsoftware.spine.timeline/Runtime/SpineAnimationState/SpineAnimationStateBehaviour.cs

@@ -48,7 +48,9 @@ namespace Spine.Unity.Playables {
 		public bool customDuration = false;
 		public bool useBlendDuration = true;
 		[SerializeField]
+		#pragma warning disable 414
 		private bool isInitialized = false; // required to read preferences values from editor side.
+		#pragma warning restore 414
 		public float mixDuration = 0.1f;
 
 		[Range(0, 1f)]