love2d.love/src/modules/graphics/vulkan/Graphics.cpp

#include "Graphics.h"
#include "Buffer.h"
#include "SDL_vulkan.h"
#include "window/Window.h"
#include "common/Exception.h"
#include "Shader.h"
#include "graphics/Texture.h"
#include "Vulkan.h"
#include "common/version.h"

#include <vector>
#include <cstring>
#include <set>
#include <fstream>
#include <iostream>
#include <array>


namespace love {
	namespace graphics {
		namespace vulkan {
			static VkIndexType getVulkanIndexBufferType(IndexDataType type) {
				switch (type) {
				case INDEX_UINT16: return VK_INDEX_TYPE_UINT16;
				case INDEX_UINT32: return VK_INDEX_TYPE_UINT32;
				default:
					throw love::Exception("unknown Index Data type");
				}
			}

			const std::vector<const char*> validationLayers = {
				"VK_LAYER_KHRONOS_validation"
			};

			const std::vector<const char*> deviceExtensions = {
				VK_KHR_SWAPCHAIN_EXTENSION_NAME
			};

#ifdef NDEBUG
			const bool enableValidationLayers = false;
#else
			const bool enableValidationLayers = true;
#endif

			const int MAX_FRAMES_IN_FLIGHT = 2;

			const char* Graphics::getName() const {
				return "love.graphics.vulkan";
			}

			Graphics::Graphics() {
			}

			Graphics::~Graphics() {
				// FIXME: most resources that are allocated dynamically need proper cleanup.
				batchedDrawState.vb[0] = nullptr;
				batchedDrawState.vb[1] = nullptr;
				batchedDrawState.indexBuffer = nullptr;
			}

			// START OVERRIDEN FUNCTIONS

			love::graphics::Buffer* Graphics::newBuffer(const love::graphics::Buffer::Settings& settings, const std::vector<love::graphics::Buffer::DataDeclaration>& format, const void* data, size_t size, size_t arraylength) {
				std::cout << "newBuffer ";
				return new Buffer(vmaAllocator, this, settings, format, data, size, arraylength);
			}

			void Graphics::startRecordingGraphicsCommands() {
				vkWaitForFences(device, 1, &inFlightFences[currentFrame], VK_TRUE, UINT64_MAX);

				while (true) {
					VkResult result = vkAcquireNextImageKHR(device, swapChain, UINT64_MAX, imageAvailableSemaphores[currentFrame], VK_NULL_HANDLE, &imageIndex);
					if (result == VK_ERROR_OUT_OF_DATE_KHR) {
						recreateSwapChain();
						continue;
					}
					else if (result != VK_SUCCESS && result != VK_SUBOPTIMAL_KHR) {
						throw love::Exception("failed to acquire swap chain image");
					}

					break;
				}

				VkCommandBufferBeginInfo beginInfo{};
				beginInfo.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO;
				beginInfo.flags = 0;
				beginInfo.pInheritanceInfo = nullptr;

				std::cout << "beginCommandBuffer(imageIndex=" << imageIndex << ") ";
				if (vkBeginCommandBuffer(commandBuffers.at(imageIndex), &beginInfo) != VK_SUCCESS) {
					throw love::Exception("failed to begin recording command buffer");
				}

				VkRenderPassBeginInfo renderPassInfo{};
				renderPassInfo.sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO;
				renderPassInfo.renderPass = renderPass;
				renderPassInfo.framebuffer = swapChainFramBuffers.at(imageIndex);
				renderPassInfo.renderArea.offset = { 0, 0 };
				renderPassInfo.renderArea.extent = swapChainExtent;
				renderPassInfo.clearValueCount = 1;
				renderPassInfo.pClearValues = &clearColor;

				const auto& commandBuffer = commandBuffers.at(imageIndex);

				vkCmdBeginRenderPass(commandBuffers.at(imageIndex), &renderPassInfo, VK_SUBPASS_CONTENTS_INLINE);
				currentGraphicsPipeline = VK_NULL_HANDLE;
			}

			void Graphics::endRecordingGraphicsCommands() {
				const auto& commandBuffer = commandBuffers.at(imageIndex);

				std::cout << "endCommandBuffer(imageIndex=" << imageIndex << ") ";
				vkCmdEndRenderPass(commandBuffers.at(imageIndex));
				if (vkEndCommandBuffer(commandBuffers.at(imageIndex)) != VK_SUCCESS) {
					throw love::Exception("failed to record command buffer");
				}
			}

			void Graphics::present(void* screenshotCallbackdata) {
				flushBatchedDraws();

				endRecordingGraphicsCommands();

				if (imagesInFlight[imageIndex] != VK_NULL_HANDLE) {
					vkWaitForFences(device, 1, &imagesInFlight.at(imageIndex), VK_TRUE, UINT64_MAX);
				}
				imagesInFlight[imageIndex] = inFlightFences[currentFrame];

				VkSubmitInfo submitInfo{};
				submitInfo.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO;

				VkSemaphore waitSemaphores[] = { imageAvailableSemaphores.at(currentFrame) };
				VkPipelineStageFlags waitStages[] = { VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT };
				submitInfo.waitSemaphoreCount = 1;
				submitInfo.pWaitSemaphores = waitSemaphores;
				submitInfo.pWaitDstStageMask = waitStages;

				submitInfo.commandBufferCount = 1;
				submitInfo.pCommandBuffers = &commandBuffers[imageIndex];

				VkSemaphore signalSemaphores[] = { renderFinishedSemaphores.at(currentFrame) };
				submitInfo.signalSemaphoreCount = 1;
				submitInfo.pSignalSemaphores = signalSemaphores;

				vkResetFences(device, 1, &inFlightFences[currentFrame]);

				if (vkQueueSubmit(graphicsQueue, 1, &submitInfo, inFlightFences.at(currentFrame)) != VK_SUCCESS) {
					throw love::Exception("failed to submit draw command buffer");
				}

				VkPresentInfoKHR presentInfo{};
				presentInfo.sType = VK_STRUCTURE_TYPE_PRESENT_INFO_KHR;

				presentInfo.waitSemaphoreCount = 1;
				presentInfo.pWaitSemaphores = signalSemaphores;

				VkSwapchainKHR swapChains[] = { swapChain };
				presentInfo.swapchainCount = 1;
				presentInfo.pSwapchains = swapChains;

				presentInfo.pImageIndices = &imageIndex;

				VkResult result = vkQueuePresentKHR(presentQueue, &presentInfo);

				if (result == VK_ERROR_OUT_OF_DATE_KHR || result == VK_SUBOPTIMAL_KHR || framebufferResized) {
					framebufferResized = false;
					recreateSwapChain();
				}
				else if (result != VK_SUCCESS) {
					throw love::Exception("failed to present swap chain image");
				}
				
				std::cout << "present" << std::endl;

				currentFrame = (currentFrame + 1) % MAX_FRAMES_IN_FLIGHT;

				updatedBatchedDrawBuffers();
				startRecordingGraphicsCommands();
			}

			void Graphics::setViewportSize(int width, int height, int pixelwidth, int pixelheight) {
				std::cout << "setViewPortSize ";
				this->width = width;
				this->height = height;
				this->pixelWidth = pixelwidth;
				this->pixelHeight = pixelheight;

				resetProjection();

				recreateSwapChain();
			}

			bool Graphics::setMode(void* context, int width, int height, int pixelwidth, int pixelheight, bool windowhasstencil, int msaa) {
				std::cout << "setMode ";

				createVulkanInstance();
				createSurface();
				pickPhysicalDevice();
				createLogicalDevice();
				initVMA();
				initCapabilities();
				createSwapChain();
				createImageViews();
				createRenderPass();
				createDefaultShaders();
				createDescriptorSetLayout();
				createFramebuffers();
				createCommandPool();
				createCommandBuffers();
				createDefaultTexture();
				createQuadIndexBuffer();
				createDescriptorPool();
				createSyncObjects();
				startRecordingGraphicsCommands();
				currentFrame = 0;

				created = true;

				float whiteColor[] = { 1.0f, 1.0f, 1.0f, 1.0f };

				batchedDrawBuffers.clear();
				batchedDrawBuffers.reserve(MAX_FRAMES_IN_FLIGHT);
				for (int i = 0; i < MAX_FRAMES_IN_FLIGHT; i++) {
					batchedDrawBuffers.emplace_back();
					// Initial sizes that should be good enough for most cases. It will
					// resize to fit if needed, later.
					batchedDrawBuffers[i].vertexBuffer1 = new StreamBuffer(vmaAllocator, BUFFERUSAGE_VERTEX, 1024 * 1024 * 1);
					batchedDrawBuffers[i].vertexBuffer2 = new StreamBuffer(vmaAllocator, BUFFERUSAGE_VERTEX, 256 * 1024 * 1);
					batchedDrawBuffers[i].indexBuffer = new StreamBuffer(vmaAllocator, BUFFERUSAGE_INDEX, sizeof(uint16) * LOVE_UINT16_MAX);

					// sometimes the VertexColor is not set, so we manually adjust it to white color
					batchedDrawBuffers[i].constantColorBuffer = new StreamBuffer(vmaAllocator, BUFFERUSAGE_VERTEX, sizeof(whiteColor));
					auto mapInfo = batchedDrawBuffers[i].constantColorBuffer->map(sizeof(whiteColor));
					memcpy(mapInfo.data, whiteColor, sizeof(whiteColor));
					batchedDrawBuffers[i].constantColorBuffer->unmap(sizeof(whiteColor));
					batchedDrawBuffers[i].constantColorBuffer->markUsed(sizeof(whiteColor));
				}

				updatedBatchedDrawBuffers();

				return true;
			}

			void Graphics::initCapabilities() {
				std::cout << "initCapabilities ";

				// todo
				capabilities.features[FEATURE_MULTI_RENDER_TARGET_FORMATS] = false;
				capabilities.features[FEATURE_CLAMP_ZERO] = false;
				capabilities.features[FEATURE_CLAMP_ONE] = false;
				capabilities.features[FEATURE_BLEND_MINMAX] = false;
				capabilities.features[FEATURE_LIGHTEN] = false;
				capabilities.features[FEATURE_FULL_NPOT] = false;
				capabilities.features[FEATURE_PIXEL_SHADER_HIGHP] = false;
				capabilities.features[FEATURE_SHADER_DERIVATIVES] = false;
				capabilities.features[FEATURE_GLSL3] = false;
				capabilities.features[FEATURE_GLSL4] = false;
				capabilities.features[FEATURE_INSTANCING] = false;
				capabilities.features[FEATURE_TEXEL_BUFFER] = false;
				capabilities.features[FEATURE_INDEX_BUFFER_32BIT] = true;
				capabilities.features[FEATURE_COPY_BUFFER] = false;
				capabilities.features[FEATURE_COPY_BUFFER_TO_TEXTURE] = false;
				capabilities.features[FEATURE_COPY_TEXTURE_TO_BUFFER] = false;
				capabilities.features[FEATURE_COPY_RENDER_TARGET_TO_BUFFER] = false;
				static_assert(FEATURE_MAX_ENUM == 17, "Graphics::initCapabilities must be updated when adding a new graphics feature!");

				VkPhysicalDeviceProperties properties;
				vkGetPhysicalDeviceProperties(physicalDevice, &properties);

				capabilities.limits[LIMIT_POINT_SIZE] = properties.limits.pointSizeRange[1];
				capabilities.limits[LIMIT_TEXTURE_SIZE] = properties.limits.maxImageDimension2D;
				capabilities.limits[LIMIT_TEXTURE_LAYERS] = properties.limits.maxImageArrayLayers;
				capabilities.limits[LIMIT_VOLUME_TEXTURE_SIZE] = properties.limits.maxImageDimension3D;
				capabilities.limits[LIMIT_CUBE_TEXTURE_SIZE] = properties.limits.maxImageDimensionCube;
				capabilities.limits[LIMIT_TEXEL_BUFFER_SIZE] = properties.limits.maxTexelBufferElements;	// ?
				capabilities.limits[LIMIT_SHADER_STORAGE_BUFFER_SIZE] = properties.limits.maxStorageBufferRange;	// ?
				capabilities.limits[LIMIT_THREADGROUPS_X] = 0;  // todo
				capabilities.limits[LIMIT_THREADGROUPS_Y] = 0;  // todo
				capabilities.limits[LIMIT_THREADGROUPS_Z] = 0;  // todo
				capabilities.limits[LIMIT_RENDER_TARGETS] = 1;	// todo
				capabilities.limits[LIMIT_TEXTURE_MSAA] = 1;	// todo
				capabilities.limits[LIMIT_ANISOTROPY] = 1.0f;	// todo
				static_assert(LIMIT_MAX_ENUM == 13, "Graphics::initCapabilities must be updated when adding a new system limit!");

				capabilities.textureTypes[TEXTURE_2D] = true;
				capabilities.textureTypes[TEXTURE_VOLUME] = false;
				capabilities.textureTypes[TEXTURE_2D_ARRAY] = false;
				capabilities.textureTypes[TEXTURE_CUBE] = false;
			}

			void Graphics::unSetMode() {
				std::cout << "unSetMode ";
				
				created = false;
				cleanup();
			}

			void Graphics::draw(const DrawIndexedCommand& cmd) {
				std::cout << "drawIndexed ";

				std::vector<VkBuffer> buffers;
				std::vector<VkDeviceSize> offsets;

				bool useConstantColorBuffer;
				GraphicsPipelineConfiguration configuration;
				createVulkanVertexFormat(*cmd.attributes, useConstantColorBuffer, configuration);

				for (uint32_t i = 0; i < 2; i++) {
					if (cmd.buffers->useBits & (1u << i)) {
						buffers.push_back((VkBuffer)cmd.buffers->info[i].buffer->getHandle());
						offsets.push_back((VkDeviceSize)cmd.buffers->info[i].offset);
					}
					else {
						buffers.push_back(VK_NULL_HANDLE);
						offsets.push_back(0);
					}
				}

				if (useConstantColorBuffer) {
					buffers.push_back((VkBuffer)batchedDrawBuffers[currentFrame].constantColorBuffer->getHandle());
					offsets.push_back((VkDeviceSize)0);
				}

				if (cmd.texture == nullptr) {
					setTexture(standardTexture);
				}
				else {
					setTexture(cmd.texture);
				}

				ensureGraphicsPipelineConfiguration(configuration);

				auto descriptorSets = getDescriptorSet(currentFrame);
				auto descriptorSet = *descriptorSets;
				vkCmdBindDescriptorSets(commandBuffers.at(imageIndex), VK_PIPELINE_BIND_POINT_GRAPHICS, pipelineLayout, 0, 1, descriptorSets, 0, nullptr);
				vkCmdBindVertexBuffers(commandBuffers.at(imageIndex), 0, buffers.size(), buffers.data(), offsets.data());
				vkCmdBindIndexBuffer(commandBuffers.at(imageIndex), (VkBuffer)cmd.indexBuffer->getHandle(), 0, getVulkanIndexBufferType(cmd.indexType));
				vkCmdDrawIndexed(commandBuffers.at(imageIndex), static_cast<uint32_t>(cmd.indexCount), 1, 0, 0, 0);
			}

			PixelFormat Graphics::getSizedFormat(PixelFormat format, bool rendertarget, bool readable) const { 
				std::cout << "getSizedFormat ";
				
				switch (format) {
				PIXELFORMAT_NORMAL:
					if (isGammaCorrect()) {
						return PIXELFORMAT_RGBA8_UNORM_sRGB;
					}
					else {
						return PIXELFORMAT_RGBA8_UNORM;
					}
				case PIXELFORMAT_HDR:
					return PIXELFORMAT_RGBA16_FLOAT;
				default:
					return format;
				}
			}

			bool Graphics::isPixelFormatSupported(PixelFormat format, uint32 usage, bool sRGB) { 
				std::cout << "isPixelFormatSupported ";
				switch (format) {
				case PIXELFORMAT_LA8_UNORM:
					return false;
				default:
					return true;
				}
			}

			void Graphics::drawQuads(int start, int count, const VertexAttributes& attributes, const BufferBindings& buffers, graphics::Texture* texture) {
				std::cout << "drawQuads ";

				const int MAX_VERTICES_PER_DRAW = LOVE_UINT16_MAX;
				const int MAX_QUADS_PER_DRAW = MAX_VERTICES_PER_DRAW / 4;

				std::vector<VkBuffer> bufferVector;
				std::vector<VkDeviceSize> offsets;

				bool useConstantColorBuffer;
				GraphicsPipelineConfiguration configuration;
				createVulkanVertexFormat(attributes, useConstantColorBuffer, configuration);

				for (uint32_t i = 0; i < 2; i++) {
					if (buffers.useBits & (1u << i)) {
						bufferVector.push_back((VkBuffer)buffers.info[i].buffer->getHandle());
						offsets.push_back((VkDeviceSize)buffers.info[i].offset);
					}
					else {
						if (useConstantColorBuffer) {
							bufferVector.push_back(VK_NULL_HANDLE);
							offsets.push_back(0);
						}
					}
				}

				if (useConstantColorBuffer) {
					bufferVector.push_back((VkBuffer)batchedDrawBuffers[currentFrame].constantColorBuffer->getHandle());
					offsets.push_back((VkDeviceSize)0);
				}

				if (texture == nullptr) {
					setTexture(standardTexture);
				}
				else {
					setTexture(texture);
				}

				ensureGraphicsPipelineConfiguration(configuration);

				vkCmdBindDescriptorSets(commandBuffers.at(imageIndex), VK_PIPELINE_BIND_POINT_GRAPHICS, pipelineLayout, 0, 1, getDescriptorSet(currentFrame), 0, nullptr);
				vkCmdBindIndexBuffer(commandBuffers.at(imageIndex), (VkBuffer)quadIndexBuffer->getHandle(), 0, getVulkanIndexBufferType(INDEX_UINT16));
				vkCmdBindVertexBuffers(commandBuffers.at(imageIndex), 0, bufferVector.size(), bufferVector.data(), offsets.data());
				vkCmdDrawIndexed(commandBuffers.at(imageIndex), static_cast<uint32_t>(count * 6), 1, 0, 0, 0);
				
				int baseVertex = start * 4;

				for (int quadindex = 0; quadindex < count; quadindex += MAX_QUADS_PER_DRAW) {
					int quadcount = std::min(MAX_QUADS_PER_DRAW, count - quadindex);

					// vkCmdDrawIndexed(commandBuffers.at(imageIndex), static_cast<uint32_t>(quadcount * 6), 1, 0, baseVertex, 0);
					baseVertex += quadcount * 4;
				}
			}

			graphics::StreamBuffer* Graphics::newStreamBuffer(BufferUsage type, size_t size) {
				std::cout << "newStreamBuffer ";
				return new StreamBuffer(vmaAllocator, type, size);
			}

			Matrix4 Graphics::computeDeviceProjection(const Matrix4& projection, bool rendertotexture) const { 
				uint32 flags = DEVICE_PROJECTION_DEFAULT;
				return calculateDeviceProjection(projection, 0);
			}

			// END IMPLEMENTATION OVERRIDDEN FUNCTIONS

			void Graphics::updatedBatchedDrawBuffers() {
				batchedDrawState.vb[0] = batchedDrawBuffers[currentFrame].vertexBuffer1;
				batchedDrawState.vb[0]->nextFrame();
				batchedDrawState.vb[1] = batchedDrawBuffers[currentFrame].vertexBuffer2; 
				batchedDrawState.vb[1]->nextFrame();
				batchedDrawState.indexBuffer = batchedDrawBuffers[currentFrame].indexBuffer;
				batchedDrawState.indexBuffer->nextFrame();
			}

			VkDescriptorSet* Graphics::getDescriptorSet(int currentFrame) {
				DecriptorSetConfiguration config;
				config.texture = currentTexture;
				config.buffer = getUniformBuffer();
				for (auto i = 0; i < descriptorSetsMap.size(); i++) {
					if (descriptorSetsMap[i].first == config) {
						return &descriptorSetsMap[i].second[currentFrame];
					}
				}
				auto descriptorSets = createDescriptorSets(config);
				descriptorSetsMap.push_back(std::make_pair(config, descriptorSets));
				return &descriptorSetsMap.back().second[currentFrame];
			}

			graphics::StreamBuffer* Graphics::getUniformBuffer() {
				auto data = getCurrentBuiltinUniformData();
				for (auto it : uniformBufferMap) {
					if (it.first == data) {
						return it.second;
					}
				}
				auto buffer = createUniformBufferFromData(data);
				uniformBufferMap.push_back(std::make_pair(data, buffer));
				return buffer;
			}

			VkCommandBuffer Graphics::beginSingleTimeCommands() {
				VkCommandBufferAllocateInfo allocInfo{};
				allocInfo.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO;
				allocInfo.level = VK_COMMAND_BUFFER_LEVEL_PRIMARY;
				allocInfo.commandPool = commandPool;
				allocInfo.commandBufferCount = 1;

				VkCommandBuffer commandBuffer;
				vkAllocateCommandBuffers(device, &allocInfo, &commandBuffer);

				VkCommandBufferBeginInfo beginInfo{};
				beginInfo.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO;
				beginInfo.flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT;

				vkBeginCommandBuffer(commandBuffer, &beginInfo);

				return commandBuffer;
			}

			void Graphics::endSingleTimeCommands(VkCommandBuffer commandBuffer) {
				vkEndCommandBuffer(commandBuffer);

				VkSubmitInfo submitInfo{};
				submitInfo.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO;
				submitInfo.commandBufferCount = 1;
				submitInfo.pCommandBuffers = &commandBuffer;

				vkQueueSubmit(graphicsQueue, 1, &submitInfo, VK_NULL_HANDLE);
				vkQueueWaitIdle(graphicsQueue);
				vkFreeCommandBuffers(device, commandPool, 1, &commandBuffer);
			}

			graphics::Shader::BuiltinUniformData Graphics::getCurrentBuiltinUniformData() {
				love::graphics::Shader::BuiltinUniformData data;

				data.transformMatrix = getTransform();
				data.projectionMatrix = getDeviceProjection();

				// The normal matrix is the transpose of the inverse of the rotation portion
				// (top-left 3x3) of the transform matrix.
				{
					Matrix3 normalmatrix = Matrix3(data.transformMatrix).transposedInverse();
					const float* e = normalmatrix.getElements();
					for (int i = 0; i < 3; i++)
					{
						data.normalMatrix[i].x = e[i * 3 + 0];
						data.normalMatrix[i].y = e[i * 3 + 1];
						data.normalMatrix[i].z = e[i * 3 + 2];
						data.normalMatrix[i].w = 0.0f;
					}
				}

				// Store DPI scale in an unused component of another vector.
				data.normalMatrix[0].w = (float)getCurrentDPIScale();

				// Same with point size.
				data.normalMatrix[1].w = getPointSize();

				data.screenSizeParams.x = swapChainExtent.width;
				data.screenSizeParams.y = swapChainExtent.height;

				data.screenSizeParams.z = 1.0f;
				data.screenSizeParams.w = 0.0f;

				data.constantColor = getColor();
				gammaCorrectColor(data.constantColor);

				return data;
			}

			graphics::StreamBuffer* Graphics::createUniformBufferFromData(graphics::Shader::BuiltinUniformData data) {
				auto buffer = newStreamBuffer(BUFFERUSAGE_UNIFORM, sizeof(data));
				auto mappedInfo = buffer->map(0);
				memcpy(mappedInfo.data, &data, sizeof(data));
				buffer->unmap(0);

				return buffer;
			}

			void Graphics::createVulkanInstance() {
				if (enableValidationLayers && !checkValidationSupport()) {
					throw love::Exception("validation layers requested, but not available");
				}

				VkApplicationInfo appInfo{};
				appInfo.sType = VK_STRUCTURE_TYPE_APPLICATION_INFO;
				appInfo.pApplicationName = "LOVE";
				appInfo.applicationVersion = VK_MAKE_VERSION(1, 0, 0);	//todo, get this version from somewhere else?
				appInfo.pEngineName = "LOVE Engine";
				appInfo.engineVersion = VK_MAKE_VERSION(VERSION_MAJOR, VERSION_MINOR, VERSION_REV);
				appInfo.apiVersion = VK_API_VERSION_1_0;

				VkInstanceCreateInfo createInfo{};
				createInfo.sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO;
				createInfo.pApplicationInfo = &appInfo;
				createInfo.pNext = nullptr;

				auto window = Module::getInstance<love::window::Window>(M_WINDOW);
				const void* handle = window->getHandle();

				unsigned int count;
				if (SDL_Vulkan_GetInstanceExtensions((SDL_Window*)handle, &count, nullptr) != SDL_TRUE) {
					throw love::Exception("couldn't retrieve sdl vulkan extensions");
				}

				std::vector<const char*> extensions = {};	// can add more here
				size_t addition_extension_count = extensions.size();
				extensions.resize(addition_extension_count + count);

				if (SDL_Vulkan_GetInstanceExtensions((SDL_Window*)handle, &count, extensions.data() + addition_extension_count) != SDL_TRUE) {
					throw love::Exception("couldn't retrieve sdl vulkan extensions");
				}

				createInfo.enabledExtensionCount = static_cast<uint32_t>(extensions.size());
				createInfo.ppEnabledExtensionNames = extensions.data();

				if (enableValidationLayers) {
					createInfo.enabledLayerCount = static_cast<uint32_t>(validationLayers.size());
					createInfo.ppEnabledLayerNames = validationLayers.data();
				}
				else {
					createInfo.enabledLayerCount = 0;
					createInfo.ppEnabledLayerNames = nullptr;
				}

				if (vkCreateInstance(
					&createInfo, 
					nullptr, 
					&instance) != VK_SUCCESS) {
					throw love::Exception("couldn't create vulkan instance");
				}
			}

			bool Graphics::checkValidationSupport() {
				uint32_t layerCount;
				vkEnumerateInstanceLayerProperties(&layerCount, nullptr);

				std::vector<VkLayerProperties> availableLayers(layerCount);
				vkEnumerateInstanceLayerProperties(&layerCount, availableLayers.data());

				for (const char* layerName : validationLayers) {
					bool layerFound = false;

					for (const auto& layerProperties : availableLayers) {
						if (strcmp(layerName, layerProperties.layerName) == 0) {
							layerFound = true;
							break;
						}
					}

					if (!layerFound) {
						return false;
					}
				}

				return true;
			}

			void Graphics::pickPhysicalDevice() {
				uint32_t deviceCount = 0;
				vkEnumeratePhysicalDevices(instance, &deviceCount, nullptr);

				if (deviceCount == 0) {
					throw love::Exception("failed to find GPUs with Vulkan support");
				}

				std::vector<VkPhysicalDevice> devices(deviceCount);
				vkEnumeratePhysicalDevices(instance, &deviceCount, devices.data());

				std::multimap<int, VkPhysicalDevice> candidates;

				for (const auto& device : devices) {
					int score = rateDeviceSuitability(device);
					candidates.insert(std::make_pair(score, device));
				}

				if (candidates.rbegin()->first > 0) {
					physicalDevice = candidates.rbegin()->second;
				}
				else {
					throw love::Exception("failed to find a suitable gpu");
				}
			}

			bool Graphics::checkDeviceExtensionSupport(VkPhysicalDevice device) {
				uint32_t extensionCount;
				vkEnumerateDeviceExtensionProperties(device, nullptr, &extensionCount, nullptr);

				std::vector<VkExtensionProperties> availableExtensions(extensionCount);
				vkEnumerateDeviceExtensionProperties(device, nullptr, &extensionCount, availableExtensions.data());

				std::set<std::string> requiredExtensions(deviceExtensions.begin(), deviceExtensions.end());

				for (const auto& extension : availableExtensions) {
					requiredExtensions.erase(extension.extensionName);
				}

				return requiredExtensions.empty();
			}

			// if the score is nonzero then the device is suitable.
			// A higher rating means generally better performance
			// if the score is 0 the device is unsuitable
			int Graphics::rateDeviceSuitability(VkPhysicalDevice device) {
				VkPhysicalDeviceProperties deviceProperties;
				VkPhysicalDeviceFeatures deviceFeatures;
				vkGetPhysicalDeviceProperties(device, &deviceProperties);
				vkGetPhysicalDeviceFeatures(device, &deviceFeatures);

				int score = 1;

				// optional 

				if (deviceProperties.deviceType == VK_PHYSICAL_DEVICE_TYPE_DISCRETE_GPU) {
					score += 1000;
				}

				// definitely needed

				QueueFamilyIndices indices = findQueueFamilies(device);
				if (!indices.isComplete()) {
					score = 0;
				}

				bool extensionsSupported = checkDeviceExtensionSupport(device);
				if (!extensionsSupported) {
					score = 0;
				}

				if (extensionsSupported) {
					auto swapChainSupport = querySwapChainSupport(device);
					bool swapChainAdequate = !swapChainSupport.formats.empty() && !swapChainSupport.presentModes.empty();
					if (!swapChainAdequate) {
						score = 0;
					}
				}

				if (!deviceFeatures.samplerAnisotropy) {
					score = 0;
				}

				return score;
			}

			Graphics::QueueFamilyIndices Graphics::findQueueFamilies(VkPhysicalDevice device) {
				QueueFamilyIndices indices;

				uint32_t queueFamilyCount = 0;
				vkGetPhysicalDeviceQueueFamilyProperties(device, &queueFamilyCount, nullptr);

				std::vector<VkQueueFamilyProperties> queueFamilies(queueFamilyCount);
				vkGetPhysicalDeviceQueueFamilyProperties(device, &queueFamilyCount, queueFamilies.data());

				int i = 0;
				for (const auto& queueFamily : queueFamilies) {
					if (queueFamily.queueFlags & VK_QUEUE_GRAPHICS_BIT) {
						indices.graphicsFamily = i;
					}

					VkBool32 presentSupport = false;
					vkGetPhysicalDeviceSurfaceSupportKHR(device, i, surface, &presentSupport);

					if (presentSupport) {
						indices.presentFamily = i;
					}

					if (indices.isComplete()) {
						break;
					}

					i++;
				}

				return indices;
			}

			void Graphics::createLogicalDevice() {
				QueueFamilyIndices indices = findQueueFamilies(physicalDevice);

				std::vector<VkDeviceQueueCreateInfo> queueCreateInfos;
				std::set<uint32_t> uniqueQueueFamilies = { indices.graphicsFamily.value(), indices.presentFamily.value() };

				float queuePriority = 1.0f;
				for (uint32_t queueFamily : uniqueQueueFamilies) {
					VkDeviceQueueCreateInfo queueCreateInfo{};
					queueCreateInfo.sType = VK_STRUCTURE_TYPE_DEVICE_QUEUE_CREATE_INFO;
					queueCreateInfo.queueFamilyIndex = queueFamily;
					queueCreateInfo.queueCount = 1;
					queueCreateInfo.pQueuePriorities = &queuePriority;
					queueCreateInfos.push_back(queueCreateInfo);
				}

				VkPhysicalDeviceFeatures deviceFeatures{};
				deviceFeatures.samplerAnisotropy = VK_TRUE;

				VkPhysicalDeviceFeatures2 deviceFeatures2{};
				deviceFeatures2.features.robustBufferAccess = VK_TRUE;
				deviceFeatures2.pNext = nullptr;

				VkDeviceCreateInfo createInfo{};
				createInfo.sType = VK_STRUCTURE_TYPE_DEVICE_CREATE_INFO;
				createInfo.queueCreateInfoCount = static_cast<uint32_t>(queueCreateInfos.size());
				createInfo.pQueueCreateInfos = queueCreateInfos.data();
				createInfo.pEnabledFeatures = &deviceFeatures;
				createInfo.pNext = &deviceFeatures2;

				createInfo.enabledExtensionCount = static_cast<uint32_t>(deviceExtensions.size());
				createInfo.ppEnabledExtensionNames = deviceExtensions.data();

				// can this be removed?
				if (enableValidationLayers) {
					createInfo.enabledLayerCount = static_cast<uint32_t>(validationLayers.size());
					createInfo.ppEnabledLayerNames = validationLayers.data();
				}
				else {
					createInfo.enabledLayerCount = 0;
				}

				if (vkCreateDevice(physicalDevice, &createInfo, nullptr, &device) != VK_SUCCESS) {
					throw love::Exception("failed to create logical device");
				}

				vkGetDeviceQueue(device, indices.graphicsFamily.value(), 0, &graphicsQueue);
				vkGetDeviceQueue(device, indices.presentFamily.value(), 0, &presentQueue);
			}

			void Graphics::initVMA() {
				VmaVulkanFunctions vulkanFunctions = {};
				vulkanFunctions.vkGetInstanceProcAddr = &vkGetInstanceProcAddr;
				vulkanFunctions.vkGetDeviceProcAddr = &vkGetDeviceProcAddr;

				VmaAllocatorCreateInfo allocatorCreateInfo = {};
				allocatorCreateInfo.vulkanApiVersion = VK_API_VERSION_1_2;
				allocatorCreateInfo.physicalDevice = physicalDevice;
				allocatorCreateInfo.device = device;
				allocatorCreateInfo.instance = instance;
				allocatorCreateInfo.pVulkanFunctions = &vulkanFunctions;

				vmaCreateAllocator(&allocatorCreateInfo, &vmaAllocator);
			}

			void Graphics::createSurface() {
				auto window = Module::getInstance<love::window::Window>(M_WINDOW);
				const void* handle = window->getHandle();
				if (SDL_Vulkan_CreateSurface((SDL_Window*)handle, instance, &surface) != SDL_TRUE) {
					throw love::Exception("failed to create window surface");
				}
			}

			Graphics::SwapChainSupportDetails Graphics::querySwapChainSupport(VkPhysicalDevice device) {
				SwapChainSupportDetails details;

				vkGetPhysicalDeviceSurfaceCapabilitiesKHR(device, surface, &details.capabilities);

				uint32_t formatCount;
				vkGetPhysicalDeviceSurfaceFormatsKHR(device, surface, &formatCount, nullptr);

				if (formatCount != 0) {
					details.formats.resize(formatCount);
					vkGetPhysicalDeviceSurfaceFormatsKHR(device, surface, &formatCount, details.formats.data());
				}

				uint32_t presentModeCount;
				vkGetPhysicalDeviceSurfacePresentModesKHR(device, surface, &presentModeCount, nullptr);

				if (presentModeCount != 0) {
					details.presentModes.resize(presentModeCount);
					vkGetPhysicalDeviceSurfacePresentModesKHR(device, surface, &presentModeCount, details.presentModes.data());
				}

				return details;
			}

			void Graphics::createSwapChain() {
				SwapChainSupportDetails swapChainSupport = querySwapChainSupport(physicalDevice);

				VkSurfaceFormatKHR surfaceFormat = chooseSwapSurfaceFormat(swapChainSupport.formats);
				VkPresentModeKHR presentMode = chooseSwapPresentMode(swapChainSupport.presentModes);
				VkExtent2D extent = chooseSwapExtent(swapChainSupport.capabilities);

				uint32_t imageCount = swapChainSupport.capabilities.minImageCount + 1;
				if (swapChainSupport.capabilities.maxImageCount > 0 && imageCount > swapChainSupport.capabilities.maxImageCount) {
					imageCount = swapChainSupport.capabilities.maxImageCount;
				}

				VkSwapchainCreateInfoKHR createInfo{};
				createInfo.sType = VK_STRUCTURE_TYPE_SWAPCHAIN_CREATE_INFO_KHR;
				createInfo.surface = surface;

				createInfo.minImageCount = imageCount;
				createInfo.imageFormat = surfaceFormat.format;
				createInfo.imageColorSpace = surfaceFormat.colorSpace;
				createInfo.imageExtent = extent;
				createInfo.imageArrayLayers = 1;
				createInfo.imageUsage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;

				QueueFamilyIndices indices = findQueueFamilies(physicalDevice);
				uint32_t queueFamilyIndices[] = { indices.graphicsFamily.value(), indices.presentFamily.value() };

				if (indices.graphicsFamily != indices.presentFamily) {
					createInfo.imageSharingMode = VK_SHARING_MODE_CONCURRENT;
					createInfo.queueFamilyIndexCount = 2;
					createInfo.pQueueFamilyIndices = queueFamilyIndices;
				}
				else {
					createInfo.imageSharingMode = VK_SHARING_MODE_EXCLUSIVE;
					createInfo.queueFamilyIndexCount = 0;
					createInfo.pQueueFamilyIndices = nullptr;
				}

				createInfo.preTransform = swapChainSupport.capabilities.currentTransform;
				createInfo.compositeAlpha = VK_COMPOSITE_ALPHA_OPAQUE_BIT_KHR;
				createInfo.presentMode = presentMode;
				createInfo.clipped = VK_TRUE;
				createInfo.oldSwapchain = VK_NULL_HANDLE;

				if (vkCreateSwapchainKHR(device, &createInfo, nullptr, &swapChain) != VK_SUCCESS) {
					throw love::Exception("failed to create swap chain");
				}

				vkGetSwapchainImagesKHR(device, swapChain, &imageCount, nullptr);
				swapChainImages.resize(imageCount);
				vkGetSwapchainImagesKHR(device, swapChain, &imageCount, swapChainImages.data());

				swapChainImageFormat = surfaceFormat.format;
				swapChainExtent = extent;
			}

			VkSurfaceFormatKHR Graphics::chooseSwapSurfaceFormat(const std::vector<VkSurfaceFormatKHR>& availableFormats) {
				for (const auto& availableFormat : availableFormats) {
					if (availableFormat.format == VK_FORMAT_B8G8R8A8_SRGB && availableFormat.colorSpace == VK_COLOR_SPACE_SRGB_NONLINEAR_KHR) {
						return availableFormat;
					}
				}

				return availableFormats[0];
			}

			VkPresentModeKHR Graphics::chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
				// needed ?
				for (const auto& availablePresentMode : availablePresentModes) {
					if (availablePresentMode == VK_PRESENT_MODE_MAILBOX_KHR) {
						return availablePresentMode;
					}
				}

				return VK_PRESENT_MODE_FIFO_KHR;
			}

			VkExtent2D Graphics::chooseSwapExtent(const VkSurfaceCapabilitiesKHR& capabilities) {
				if (capabilities.currentExtent.width != UINT32_MAX) {
					return capabilities.currentExtent;
				}
				else {
					auto window = Module::getInstance<love::window::Window>(M_WINDOW);
					const void* handle = window->getHandle();

					int width, height;
					// is this the equivalent of glfwGetFramebufferSize ?
					SDL_Vulkan_GetDrawableSize((SDL_Window*)handle, &width, &height);

					VkExtent2D actualExtent = {
						static_cast<uint32_t>(width),
						static_cast<uint32_t>(height)
					};

					actualExtent.width = std::clamp(actualExtent.width, capabilities.minImageExtent.width, capabilities.maxImageExtent.width);
					actualExtent.height = std::clamp(actualExtent.height, capabilities.minImageExtent.height, capabilities.maxImageExtent.height);

					return actualExtent;
				}
			}

			void Graphics::createImageViews() {
				swapChainImageViews.resize(swapChainImages.size());

				for (size_t i = 0; i < swapChainImages.size(); i++) {
					VkImageViewCreateInfo createInfo{};
					createInfo.sType = VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO;
					createInfo.image = swapChainImages.at(i);
					createInfo.viewType = VK_IMAGE_VIEW_TYPE_2D;
					createInfo.format = swapChainImageFormat;
					createInfo.components.r = VK_COMPONENT_SWIZZLE_IDENTITY;
					createInfo.components.g = VK_COMPONENT_SWIZZLE_IDENTITY;
					createInfo.components.b = VK_COMPONENT_SWIZZLE_IDENTITY;
					createInfo.components.a = VK_COMPONENT_SWIZZLE_IDENTITY;
					createInfo.subresourceRange.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
					createInfo.subresourceRange.baseMipLevel = 0;
					createInfo.subresourceRange.levelCount = 1;
					createInfo.subresourceRange.baseArrayLayer = 0;
					createInfo.subresourceRange.layerCount = 1;

					if (vkCreateImageView(device, &createInfo, nullptr, &swapChainImageViews.at(i)) != VK_SUCCESS) {
						throw love::Exception("failed to create image views");
					}
				}
			}

			void Graphics::createRenderPass() {
				VkAttachmentDescription colorAttachment{};
				colorAttachment.format = swapChainImageFormat;
				colorAttachment.samples = VK_SAMPLE_COUNT_1_BIT;
				colorAttachment.loadOp = VK_ATTACHMENT_LOAD_OP_CLEAR;
				colorAttachment.storeOp = VK_ATTACHMENT_STORE_OP_STORE;
				colorAttachment.stencilLoadOp = VK_ATTACHMENT_LOAD_OP_DONT_CARE;
				colorAttachment.stencilStoreOp = VK_ATTACHMENT_STORE_OP_DONT_CARE;
				colorAttachment.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
				colorAttachment.finalLayout = VK_IMAGE_LAYOUT_PRESENT_SRC_KHR;

				VkAttachmentReference colorAttachmentRef{};
				colorAttachmentRef.attachment = 0;
				colorAttachmentRef.layout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL;

				VkSubpassDescription subpass{};
				subpass.pipelineBindPoint = VK_PIPELINE_BIND_POINT_GRAPHICS;
				subpass.colorAttachmentCount = 1;
				subpass.pColorAttachments = &colorAttachmentRef;

				VkSubpassDependency dependency{};
				dependency.srcSubpass = VK_SUBPASS_EXTERNAL;
				dependency.dstSubpass = 0;
				dependency.srcStageMask = VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT;
				dependency.srcAccessMask = 0;
				dependency.dstStageMask = VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT;
				dependency.dstAccessMask = VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT;

				VkRenderPassCreateInfo renderPassInfo{};
				renderPassInfo.sType = VK_STRUCTURE_TYPE_RENDER_PASS_CREATE_INFO;
				renderPassInfo.attachmentCount = 1;
				renderPassInfo.pAttachments = &colorAttachment;
				renderPassInfo.subpassCount = 1;
				renderPassInfo.pSubpasses = &subpass;
				renderPassInfo.dependencyCount = 1;
				renderPassInfo.pDependencies = &dependency;

				if (vkCreateRenderPass(device, &renderPassInfo, nullptr, &renderPass) != VK_SUCCESS) {
					throw love::Exception("failed to create render pass");
				}
			}

			void Graphics::createDefaultShaders() {
				for (int i = 0; i < Shader::STANDARD_MAX_ENUM; i++) {
					auto stype = (Shader::StandardShader)i;

					if (!Shader::standardShaders[i]) {
						std::vector<std::string> stages;
						stages.push_back(Shader::getDefaultCode(stype, SHADERSTAGE_VERTEX));
						stages.push_back(Shader::getDefaultCode(stype, SHADERSTAGE_PIXEL));
						Shader::standardShaders[i] = newShader(stages, { { {"vulkan", "1"} } });
					}
				}
			}

			void Graphics::createDescriptorSetLayout() {
				VkDescriptorSetLayoutBinding uboLayoutBinding{};
				uboLayoutBinding.binding = 0;
				uboLayoutBinding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER;
				uboLayoutBinding.descriptorCount = 1;
				uboLayoutBinding.stageFlags = VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_FRAGMENT_BIT;

				VkDescriptorSetLayoutBinding samplerLayoutBinding{};
				samplerLayoutBinding.binding = 1;
				samplerLayoutBinding.descriptorCount = 1;
				samplerLayoutBinding.descriptorType = VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER;
				samplerLayoutBinding.pImmutableSamplers = nullptr;
				samplerLayoutBinding.stageFlags = VK_SHADER_STAGE_FRAGMENT_BIT;

				std::array<VkDescriptorSetLayoutBinding, 2> bindings = { uboLayoutBinding, samplerLayoutBinding };
				VkDescriptorSetLayoutCreateInfo layoutInfo{};
				layoutInfo.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO;
				layoutInfo.bindingCount = static_cast<uint32_t>(bindings.size());
				layoutInfo.pBindings = bindings.data();

				if (vkCreateDescriptorSetLayout(device, &layoutInfo, nullptr, &descriptorSetLayout) != VK_SUCCESS) {
					throw love::Exception("failed to create descriptor set layout");
				}
			}

			void Graphics::createDescriptorPool() {
				std::array<VkDescriptorPoolSize, 2> poolSizes{};
				poolSizes[0].type = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER;
				poolSizes[0].descriptorCount = static_cast<uint32_t>(MAX_FRAMES_IN_FLIGHT);
				poolSizes[1].type = VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER;
				poolSizes[1].descriptorCount = static_cast<uint32_t>(MAX_FRAMES_IN_FLIGHT);

				VkDescriptorPoolCreateInfo poolInfo{};
				poolInfo.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO;
				poolInfo.poolSizeCount = static_cast<uint32_t>(poolSizes.size());
				poolInfo.pPoolSizes = poolSizes.data();
				// FIXME: When using more than 128 textures at once we will run out of memory.
				// we probably want to reuse descriptors per flight image
				// and use multiple pools in case of too many allocations
				poolInfo.maxSets = 128 * static_cast<uint32_t>(MAX_FRAMES_IN_FLIGHT);

				if (vkCreateDescriptorPool(device, &poolInfo, nullptr, &descriptorPool) != VK_SUCCESS) {
					throw love::Exception("failed to create descriptor pool");
				}
			}

			std::vector<VkDescriptorSet> Graphics::createDescriptorSets(DecriptorSetConfiguration config) {
				std::vector<VkDescriptorSetLayout> layouts(MAX_FRAMES_IN_FLIGHT, descriptorSetLayout);
				VkDescriptorSetAllocateInfo allocInfo{};
				allocInfo.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_ALLOCATE_INFO;
				allocInfo.descriptorPool = descriptorPool;
				allocInfo.descriptorSetCount = static_cast<uint32_t>(MAX_FRAMES_IN_FLIGHT);
				allocInfo.pSetLayouts = layouts.data();

				std::vector<VkDescriptorSet> newDescriptorSets;

				newDescriptorSets.resize(MAX_FRAMES_IN_FLIGHT);
				VkResult result = vkAllocateDescriptorSets(device, &allocInfo, newDescriptorSets.data());
				if (result != VK_SUCCESS) {
					switch (result) {
					case VK_ERROR_OUT_OF_HOST_MEMORY:
						throw love::Exception("failed to allocate descriptor sets: out of host memory");
					case VK_ERROR_OUT_OF_DEVICE_MEMORY:
						throw love::Exception("failed to allocate descriptor sets: out of device memory");
					case VK_ERROR_FRAGMENTED_POOL:
						throw love::Exception("failed to allocate descriptor sets: fragmented pool");
					case VK_ERROR_OUT_OF_POOL_MEMORY:
						throw love::Exception("failed to allocate descriptor sets: out of pool memory");
					default:
						throw love::Exception("failed to allocate descriptor sets");
					}
				}

				for (size_t i = 0; i < MAX_FRAMES_IN_FLIGHT; i++) {
					VkDescriptorBufferInfo bufferInfo{};
					bufferInfo.buffer = (VkBuffer)config.buffer->getHandle();
					bufferInfo.offset = 0;
					bufferInfo.range = sizeof(graphics::Shader::BuiltinUniformData);

					VkDescriptorImageInfo imageInfo{};
					imageInfo.imageLayout = VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL;
					Texture* vkTexture = (Texture*)config.texture;
					imageInfo.imageView = vkTexture->getImageView();
					imageInfo.sampler = vkTexture->getSampler();

					std::array<VkWriteDescriptorSet, 2> descriptorWrite{};
					descriptorWrite[0].sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET;
					descriptorWrite[0].dstSet = newDescriptorSets[i];
					descriptorWrite[0].dstBinding = 0;
					descriptorWrite[0].dstArrayElement = 0;
					descriptorWrite[0].descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER;
					descriptorWrite[0].descriptorCount = 1;
					descriptorWrite[0].pBufferInfo = &bufferInfo;

					descriptorWrite[1].sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET;
					descriptorWrite[1].dstSet = newDescriptorSets[i];
					descriptorWrite[1].dstBinding = 1;
					descriptorWrite[1].dstArrayElement = 0;
					descriptorWrite[1].descriptorType = VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER;
					descriptorWrite[1].descriptorCount = 1;
					descriptorWrite[1].pImageInfo = &imageInfo;

					vkUpdateDescriptorSets(device, static_cast<uint32_t>(descriptorWrite.size()), descriptorWrite.data(), 0, nullptr);
				}

				return newDescriptorSets;
			}

			void Graphics::createVulkanVertexFormat(
				VertexAttributes vertexAttributes, 
				bool& useConstantVertexColor,
				GraphicsPipelineConfiguration& configuration) {
				std::set<uint32_t> usedBuffers;
				std::vector<VkVertexInputBindingDescription> bindingDescriptions;
				std::vector<VkVertexInputAttributeDescription> attributeDescriptions;

				auto allBits = vertexAttributes.enableBits;

				bool usesColor = false;
				
				for (uint32_t i = 0; i < VertexAttributes::MAX; i++) {	// change to loop like in opengl implementation ?
					uint32 bit = 1u << i;
					if (allBits & bit) {
						if (i == ATTRIB_COLOR) {
							usesColor = true;
						}

						auto attrib = vertexAttributes.attribs[i];
						auto bufferBinding = attrib.bufferIndex;
						if (usedBuffers.find(bufferBinding) == usedBuffers.end()) {	// use .contains() when c++20 is enabled
							usedBuffers.insert(bufferBinding);

							VkVertexInputBindingDescription bindingDescription{};
							bindingDescription.binding = bufferBinding;
							bindingDescription.inputRate = VK_VERTEX_INPUT_RATE_VERTEX;
							bindingDescription.stride = vertexAttributes.bufferLayouts[bufferBinding].stride;
							bindingDescriptions.push_back(bindingDescription);
						}

						VkVertexInputAttributeDescription attributeDescription{};
						attributeDescription.location = i;
						attributeDescription.binding = bufferBinding;
						attributeDescription.offset = attrib.offsetFromVertex;
						attributeDescription.format = Vulkan::getVulkanVertexFormat(attrib.format);

						attributeDescriptions.push_back(attributeDescription);
					}
				}

				// do we need to use a constant VertexColor?
				if (!usesColor) {
					constexpr uint32_t constantColorBufferBinding = 2;

					VkVertexInputBindingDescription bindingDescription{};
					bindingDescription.binding = constantColorBufferBinding;
					bindingDescription.inputRate = VK_VERTEX_INPUT_RATE_VERTEX;
					bindingDescription.stride = 0;	// no stride, will always read the same color multiple times.
					bindingDescriptions.push_back(bindingDescription);

					VkVertexInputAttributeDescription attributeDescription{};
					attributeDescription.binding = constantColorBufferBinding;
					attributeDescription.location = ATTRIB_COLOR;
					attributeDescription.offset = 0;
					attributeDescription.format = VK_FORMAT_R32G32B32A32_SFLOAT;

					useConstantVertexColor = true;
				}
				else {
					useConstantVertexColor = false;
				}

				configuration.vertexInputBindingDescriptions = bindingDescriptions;
				configuration.vertexInputAttributeDescriptions = attributeDescriptions;
			}

			VkPipeline Graphics::createGraphicsPipeline(GraphicsPipelineConfiguration configuration) {
				auto shader = reinterpret_cast<love::graphics::vulkan::Shader*>(love::graphics::vulkan::Shader::standardShaders[Shader::STANDARD_DEFAULT]);
				auto shaderStages = shader->getShaderStages();

				VkPipelineVertexInputStateCreateInfo vertexInputInfo{};
				vertexInputInfo.sType = VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO;

				vertexInputInfo.vertexBindingDescriptionCount = configuration.vertexInputBindingDescriptions.size();
				vertexInputInfo.pVertexBindingDescriptions = configuration.vertexInputBindingDescriptions.data();
				vertexInputInfo.vertexAttributeDescriptionCount = configuration.vertexInputAttributeDescriptions.size();
				vertexInputInfo.pVertexAttributeDescriptions = configuration.vertexInputAttributeDescriptions.data();

				VkPipelineInputAssemblyStateCreateInfo inputAssembly{};
				inputAssembly.sType = VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO;
				inputAssembly.topology = VK_PRIMITIVE_TOPOLOGY_TRIANGLE_LIST;
				inputAssembly.primitiveRestartEnable = VK_FALSE;
				
				VkViewport viewport{};
				viewport.x = 0.0f;
				viewport.y = 0.0f;
				viewport.width = (float)swapChainExtent.width;
				viewport.height = (float)swapChainExtent.height;
				viewport.minDepth = 0.0f;
				viewport.maxDepth = 1.0f;

				VkRect2D scissor{};
				scissor.offset = { 0, 0 };
				scissor.extent = swapChainExtent;

				VkPipelineViewportStateCreateInfo viewportState{};
				viewportState.sType = VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO;
				viewportState.viewportCount = 1;
				viewportState.pViewports = &viewport;
				viewportState.scissorCount = 1;
				viewportState.pScissors = &scissor;

				VkPipelineRasterizationStateCreateInfo rasterizer{};
				rasterizer.sType = VK_STRUCTURE_TYPE_PIPELINE_RASTERIZATION_STATE_CREATE_INFO;
				rasterizer.depthClampEnable = VK_FALSE;
				rasterizer.rasterizerDiscardEnable = VK_FALSE;
				rasterizer.polygonMode = VK_POLYGON_MODE_FILL;
				rasterizer.lineWidth = 1.0f;
				rasterizer.cullMode = VK_CULL_MODE_FRONT_BIT;
				rasterizer.frontFace = VK_FRONT_FACE_CLOCKWISE;
				rasterizer.depthBiasEnable = VK_FALSE;
				rasterizer.depthBiasConstantFactor = 0.0f;
				rasterizer.depthBiasClamp = 0.0f;
				rasterizer.depthBiasSlopeFactor = 0.0f;

				VkPipelineMultisampleStateCreateInfo multisampling{};
				multisampling.sType = VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO;
				multisampling.sampleShadingEnable = VK_FALSE;
				multisampling.rasterizationSamples = VK_SAMPLE_COUNT_1_BIT;
				multisampling.minSampleShading = 1.0f; // Optional
				multisampling.pSampleMask = nullptr; // Optional
				multisampling.alphaToCoverageEnable = VK_FALSE; // Optional
				multisampling.alphaToOneEnable = VK_FALSE; // Optional

				VkPipelineColorBlendAttachmentState colorBlendAttachment{};
				colorBlendAttachment.colorWriteMask = VK_COLOR_COMPONENT_R_BIT | VK_COLOR_COMPONENT_G_BIT | VK_COLOR_COMPONENT_B_BIT | VK_COLOR_COMPONENT_A_BIT;
				colorBlendAttachment.blendEnable = VK_FALSE;

				VkPipelineColorBlendStateCreateInfo colorBlending{};
				colorBlending.sType = VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO;
				colorBlending.logicOpEnable = VK_FALSE;
				colorBlending.logicOp = VK_LOGIC_OP_COPY;
				colorBlending.attachmentCount = 1;
				colorBlending.pAttachments = &colorBlendAttachment;
				colorBlending.blendConstants[0] = 0.0f;
				colorBlending.blendConstants[1] = 0.0f;
				colorBlending.blendConstants[2] = 0.0f;
				colorBlending.blendConstants[3] = 0.0f;

				VkPipelineLayoutCreateInfo pipelineLayoutInfo{};
				pipelineLayoutInfo.sType = VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO;
				pipelineLayoutInfo.setLayoutCount = 1;
				pipelineLayoutInfo.pSetLayouts = &descriptorSetLayout;
				pipelineLayoutInfo.pushConstantRangeCount = 0;

				if (vkCreatePipelineLayout(device, &pipelineLayoutInfo, nullptr, &pipelineLayout) != VK_SUCCESS) {
					throw love::Exception("failed to create pipeline layout");
				}

				VkGraphicsPipelineCreateInfo pipelineInfo{};
				pipelineInfo.sType = VK_STRUCTURE_TYPE_GRAPHICS_PIPELINE_CREATE_INFO;
				pipelineInfo.stageCount = static_cast<uint32_t>(shaderStages.size());
				pipelineInfo.pStages = shaderStages.data();
				pipelineInfo.pVertexInputState = &vertexInputInfo;
				pipelineInfo.pInputAssemblyState = &inputAssembly;
				pipelineInfo.pViewportState = &viewportState;
				pipelineInfo.pRasterizationState = &rasterizer;
				pipelineInfo.pMultisampleState = &multisampling;
				pipelineInfo.pDepthStencilState = nullptr;
				pipelineInfo.pColorBlendState = &colorBlending;
				pipelineInfo.pDynamicState = nullptr;
				pipelineInfo.layout = pipelineLayout;
				pipelineInfo.renderPass = renderPass;
				pipelineInfo.subpass = 0;
				pipelineInfo.basePipelineHandle = VK_NULL_HANDLE;
				pipelineInfo.basePipelineIndex = -1;

				VkPipeline graphicsPipeline;
				if (vkCreateGraphicsPipelines(device, VK_NULL_HANDLE, 1, &pipelineInfo, nullptr, &graphicsPipeline) != VK_SUCCESS) {
					throw love::Exception("failed to create graphics pipeline");
				}
				return graphicsPipeline;
			}

			void Graphics::ensureGraphicsPipelineConfiguration(GraphicsPipelineConfiguration configuration) {
				VkPipeline pipeline = VK_NULL_HANDLE;
				for (auto const& p : graphicsPipelines) {
					if (p.first == configuration) {
						pipeline = p.second;
						break;
					}
				}
				if (pipeline != VK_NULL_HANDLE) {
					if (currentGraphicsPipeline != pipeline) {
						vkCmdBindPipeline(commandBuffers.at(imageIndex), VK_PIPELINE_BIND_POINT_GRAPHICS, pipeline);
						currentGraphicsPipeline = pipeline;
					}
				} else {
					VkPipeline newPipeLine = createGraphicsPipeline(configuration);
					graphicsPipelines.push_back(std::make_pair(configuration, newPipeLine));
					vkCmdBindPipeline(commandBuffers.at(imageIndex), VK_PIPELINE_BIND_POINT_GRAPHICS, newPipeLine);
					currentGraphicsPipeline = newPipeLine;
				}
			}

			void Graphics::createFramebuffers() {
				swapChainFramBuffers.resize(swapChainImageViews.size());
				for (size_t i = 0; i < swapChainImageViews.size(); i++) {
					VkImageView attachments[] = {
						swapChainImageViews.at(i)
					};

					VkFramebufferCreateInfo framebufferInfo{};
					framebufferInfo.sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO;
					framebufferInfo.renderPass = renderPass;
					framebufferInfo.attachmentCount = 1;
					framebufferInfo.pAttachments = attachments;
					framebufferInfo.width = swapChainExtent.width;
					framebufferInfo.height = swapChainExtent.height;
					framebufferInfo.layers = 1;

					if (vkCreateFramebuffer(device, &framebufferInfo, nullptr, &swapChainFramBuffers.at(i)) != VK_SUCCESS) {
						throw love::Exception("failed to create framebuffers");
					}
				}
			}

			void Graphics::createCommandPool() {
				QueueFamilyIndices queueFamilyIndices = findQueueFamilies(physicalDevice);

				VkCommandPoolCreateInfo poolInfo{};
				poolInfo.sType = VK_STRUCTURE_TYPE_COMMAND_POOL_CREATE_INFO;
				poolInfo.queueFamilyIndex = queueFamilyIndices.graphicsFamily.value();
				poolInfo.flags = VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT;

				if (vkCreateCommandPool(device, &poolInfo, nullptr, &commandPool) != VK_SUCCESS) {
					throw love::Exception("failed to create command pool");
				}
			}

			void Graphics::createCommandBuffers() {
				commandBuffers.resize(swapChainFramBuffers.size());

				VkCommandBufferAllocateInfo allocInfo{};
				allocInfo.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO;
				allocInfo.commandPool = commandPool;
				allocInfo.level = VK_COMMAND_BUFFER_LEVEL_PRIMARY;
				allocInfo.commandBufferCount = (uint32_t)commandBuffers.size();

				if (vkAllocateCommandBuffers(device, &allocInfo, commandBuffers.data()) != VK_SUCCESS) {
					throw love::Exception("failed to allocate command buffers");
				}
			}

			void Graphics::createSyncObjects() {
				imageAvailableSemaphores.resize(MAX_FRAMES_IN_FLIGHT);
				renderFinishedSemaphores.resize(MAX_FRAMES_IN_FLIGHT);
				inFlightFences.resize(MAX_FRAMES_IN_FLIGHT);
				imagesInFlight.resize(swapChainImages.size(), VK_NULL_HANDLE);

				VkSemaphoreCreateInfo semaphoreInfo{};
				semaphoreInfo.sType = VK_STRUCTURE_TYPE_SEMAPHORE_CREATE_INFO;

				VkFenceCreateInfo fenceInfo{};
				fenceInfo.sType = VK_STRUCTURE_TYPE_FENCE_CREATE_INFO;
				fenceInfo.flags = VK_FENCE_CREATE_SIGNALED_BIT;

				for (size_t i = 0; i < MAX_FRAMES_IN_FLIGHT; i++) {
					if (vkCreateSemaphore(device, &semaphoreInfo, nullptr, &imageAvailableSemaphores.at(i)) != VK_SUCCESS ||
						vkCreateSemaphore(device, &semaphoreInfo, nullptr, &renderFinishedSemaphores.at(i)) != VK_SUCCESS ||
						vkCreateFence(device, &fenceInfo, nullptr, &inFlightFences.at(i)) != VK_SUCCESS) {
						throw love::Exception("failed to create synchronization objects for a frame!");
					}
				}
			}

			void Graphics::createDefaultTexture() {
				Texture::Settings settings;
				standardTexture = newTexture(settings);
			}

			void Graphics::createQuadIndexBuffer() {
				if (quadIndexBuffer != nullptr)
					return;

				size_t size = sizeof(uint16) * getIndexCount(TRIANGLEINDEX_QUADS, LOVE_UINT16_MAX);
				quadIndexBuffer = static_cast<StreamBuffer*>(newStreamBuffer(BUFFERUSAGE_INDEX, size));
				auto map = quadIndexBuffer->map(size);
				fillIndices(TRIANGLEINDEX_QUADS, 0, LOVE_UINT16_MAX, (uint16*)map.data);
				quadIndexBuffer->unmap(size);
			}

			bool operator==(const Graphics::GraphicsPipelineConfiguration& first, const Graphics::GraphicsPipelineConfiguration& other) {
				if (first.vertexInputAttributeDescriptions.size() != other.vertexInputAttributeDescriptions.size()) {
					return false;
				}
				if (first.vertexInputBindingDescriptions.size() != other.vertexInputBindingDescriptions.size()) {
					return false;
				}
				for (uint32_t i = 0; i < first.vertexInputAttributeDescriptions.size(); i++) {
					const VkVertexInputAttributeDescription& x = first.vertexInputAttributeDescriptions[i];
					const VkVertexInputAttributeDescription& y = other.vertexInputAttributeDescriptions[i];
					if (x.binding != y.binding) {
						return false;
					}
					if (x.location != y.location) {
						return false;
					}
					if (x.offset != y.offset) {
						return false;
					}
					if (x.format != y.format) {
						return false;
					}
				}
				for (uint32_t i = 0; i < first.vertexInputBindingDescriptions.size(); i++) {
					const VkVertexInputBindingDescription& x = first.vertexInputBindingDescriptions[i];
					const VkVertexInputBindingDescription& y = other.vertexInputBindingDescriptions[i];
					if (x.binding != y.binding) {
						return false;
					}
					if (x.inputRate != y.inputRate) {
						return false;
					}
					if (x.stride != y.stride) {
						return false;
					}
				}
				return true;
			}

			void Graphics::cleanup() {
				vkDeviceWaitIdle(device);

				cleanupSwapChain();

				for (size_t i = 0; i < MAX_FRAMES_IN_FLIGHT; i++) {
					vkDestroySemaphore(device, renderFinishedSemaphores[i], nullptr);
					vkDestroySemaphore(device, imageAvailableSemaphores[i], nullptr);
					vkDestroyFence(device, inFlightFences[i], nullptr);
				}

				vkDestroyDescriptorPool(device, descriptorPool, nullptr);

				vkDestroyDescriptorSetLayout(device, descriptorSetLayout, nullptr);
				vkDestroyCommandPool(device, commandPool, nullptr);
				vkDestroyDevice(device, nullptr);
				vkDestroySurfaceKHR(instance, surface, nullptr);
				vkDestroyInstance(instance, nullptr);
			}

			void Graphics::cleanupSwapChain() {
				std::cout << "cleanupSwapChain ";

				for (size_t i = 0; i < swapChainFramBuffers.size(); i++) {
					vkDestroyFramebuffer(device, swapChainFramBuffers[i], nullptr);
				}
				vkFreeCommandBuffers(device, commandPool, static_cast<uint32_t>(commandBuffers.size()), commandBuffers.data());
				for (auto const& p : graphicsPipelines) {
					vkDestroyPipeline(device, p.second, nullptr);
				}
				graphicsPipelines.clear();
				currentGraphicsPipeline = VK_NULL_HANDLE;
				// vkDestroyPipelineLayout(device, pipelineLayout, nullptr); FIXME
				vkDestroyRenderPass(device, renderPass, nullptr);
				for (size_t i = 0; i < swapChainImageViews.size(); i++) {
					vkDestroyImageView(device, swapChainImageViews[i], nullptr);
				}
				vkDestroySwapchainKHR(device, swapChain, nullptr);
				uniformBufferMap.clear();
				descriptorSetsMap.clear();
			}

			void Graphics::recreateSwapChain() {
				vkDeviceWaitIdle(device);

				cleanupSwapChain();

				createSwapChain();
				createImageViews();
				createRenderPass();
				createFramebuffers();
				createDescriptorPool();
				createCommandBuffers();
				startRecordingGraphicsCommands();
			}

			love::graphics::Graphics* createInstance() {
				love::graphics::Graphics* instance = nullptr;

				try {
					instance = new Graphics();
				}
				catch (love::Exception& e) {
					printf("Cannot create Vulkan renderer: %s\n", e.what());
				}

				return instance;
			}
		}
	}
}