Browse Source

removed unecessary attribute

vpenades 1 year ago
parent
commit
779ca4aca8

+ 2 - 1
tests/SharpGLTF.Core.Tests/Validation/InvalidFilesTests.cs

@@ -74,8 +74,9 @@ namespace SharpGLTF.Validation
                 // https://github.com/KhronosGroup/glTF-Validator/issues/189
                 if (f.EndsWith("node_weights_override.gltf")) continue;
                 if (f.EndsWith("valid_with_tangent.gltf")) continue;
+                // if (f.EndsWith("custom_property.gltf")) continue;               
 
-                // if (!f.EndsWith("out_of_range.gltf")) continue;
+                if (!f.EndsWith("custom_property.gltf")) continue;
 
                 var gltfJson = f.EndsWith(".gltf") ? System.IO.File.ReadAllText(f) : string.Empty;
                 

+ 2 - 3
tests/SharpGLTF.NUnit/TestFiles.cs

@@ -144,13 +144,12 @@ namespace SharpGLTF
         {
             var skip = new string[]
             {
-                "empty_object.gltf", // need to look further
-                "custom_property.gltf",
+                "empty_object.gltf", // need to look further                
                 "integer_written_as_float.gltf",
                 "unknown_type.gltf",
                 "valid.gltf", // valid just because objects are unused
                 "get_elements_sparse.gltf", // valid just because objects are unused
-                "invalid_elements_float.gltf", // sure, it has invalid floats, but then the accessor is not used.
+                "invalid_elements_float.gltf", // sure, it has invalid floats, but then the accessor is not used by the current scene. But what if the accessor is used externally, or by an unhalded extension?
                 "not_found.gltf", // it fails at a tricky time
                 "non_relative_uri.gltf", // absolute path pointing to a http which is not supported.
                 "unrecognized_format.gltf", // might require to dig into the image