Parcourir la source

EdgesGeometry: Correct thresholdAngle description in docs and source code

Mugen87 il y a 8 ans
Parent
commit
6b0fc6e35f
2 fichiers modifiés avec 2 ajouts et 3 suppressions
  1. 1 1
      docs/api/geometries/EdgesGeometry.html
  2. 1 2
      src/geometries/EdgesGeometry.js

+ 1 - 1
docs/api/geometries/EdgesGeometry.html

@@ -30,7 +30,7 @@ scene.add( line );
 		<h3>[name]( [page:Geometry geometry], [page:Integer thresholdAngle] )</h3>
 		<h3>[name]( [page:Geometry geometry], [page:Integer thresholdAngle] )</h3>
 		<div>
 		<div>
 		geometry — Any geometry object.<br />
 		geometry — Any geometry object.<br />
-		thresholdAngle — A valid edge is only detected if the angle between two consecutive faces is greater than this value, default = 1.
+		thresholdAngle — An edge is only rendered if the angle (in degrees) between the face normals of the adjoining faces exceeds this value. default = 1 degree.
 		</div>
 		</div>
 
 
 		<h2>Source</h2>
 		<h2>Source</h2>

+ 1 - 2
src/geometries/EdgesGeometry.js

@@ -76,8 +76,7 @@ function EdgesGeometry( geometry, thresholdAngle ) {
 
 
 		var h = hash[ key ];
 		var h = hash[ key ];
 
 
-		// A valid edge is only detected if the angle between two consecutive faces is greater than the given threshold angle.
-		// The implementation detects this via the dot product of two consecutive faces normals.
+		// An edge is only rendered if the angle (in degrees) between the face normals of the adjoining faces exceeds this value. default = 1 degree.
 
 
 		if ( h.face2 === undefined || faces[ h.face1 ].normal.dot( faces[ h.face2 ].normal ) <= thresholdDot ) {
 		if ( h.face2 === undefined || faces[ h.face1 ].normal.dot( faces[ h.face2 ].normal ) <= thresholdDot ) {