Browse Source

Changed Euler Copy Clone on change test implementation.

Because the previous implementation gave inconsistent behavior due to
QUnit step behavior.
levilime 7 years ago
parent
commit
d4042e1eb9
1 changed files with 15 additions and 10 deletions
  1. 15 10
      test/unit/src/math/Euler.tests.js

+ 15 - 10
test/unit/src/math/Euler.tests.js

@@ -225,27 +225,32 @@ export default QUnit.module( 'Maths', () => {
 
 
 		QUnit.test( "clone/copy, check callbacks", ( assert ) => {
 		QUnit.test( "clone/copy, check callbacks", ( assert ) => {
 
 
-			assert.expect( 3 );
-
-			var a = new Euler( 1, 2, 3, "ZXY" );
+            var a = new Euler( 1, 2, 3, "ZXY" );
 			var b = new Euler( 4, 5, 6, "XZY" );
 			var b = new Euler( 4, 5, 6, "XZY" );
-			var cb = function () {
+			var cbSucceed = function () {
 
 
-				assert.step( "onChange called" );
+    			assert.ok( true );
+    			assert.step( "onChange called" );
 
 
 			};
 			};
-			a.onChange( cb );
-			b.onChange( cb );
+			var cbFail = function () {
+
+			    assert.ok( false );
+
+			};
+			a.onChange( cbFail );
+			b.onChange( cbFail );
 
 
 			// clone doesn't trigger onChange
 			// clone doesn't trigger onChange
-			var a = b.clone();
+			a = b.clone();
 			assert.ok( a.equals( b ), "clone: check if a equals b" );
 			assert.ok( a.equals( b ), "clone: check if a equals b" );
 
 
 			// copy triggers onChange once
 			// copy triggers onChange once
-			var a = new Euler( 1, 2, 3, "ZXY" );
-			a.onChange( cb );
+			a = new Euler( 1, 2, 3, "ZXY" );
+			a.onChange( cbSucceed );
 			a.copy( b );
 			a.copy( b );
 			assert.ok( a.equals( b ), "copy: check if a equals b" );
 			assert.ok( a.equals( b ), "copy: check if a equals b" );
+			assert.verifySteps( [ "onChange called" ] );
 
 
 		} );
 		} );