Browse Source

Merge pull request #36187 from Chaosus/shader_forbid_out_samplers

Prevent usage 'out' modifier on opaque shader types (textures currently)
Yuri Roubinsky 5 years ago
parent
commit
234d355081
1 changed files with 7 additions and 0 deletions
  1. 7 0
      servers/visual/shader_language.cpp

+ 7 - 0
servers/visual/shader_language.cpp

@@ -6273,6 +6273,13 @@ Error ShaderLanguage::_parse_shader(const Map<StringName, FunctionInfo> &p_funct
 						return ERR_PARSE_ERROR;
 					}
 
+					if (qualifier == ARGUMENT_QUALIFIER_OUT || qualifier == ARGUMENT_QUALIFIER_INOUT) {
+						if (is_sampler_type(get_token_datatype(tk.type))) {
+							_set_error("Opaque types cannot be output parameters.");
+							return ERR_PARSE_ERROR;
+						}
+					}
+
 					if (is_struct) {
 						ptype = TYPE_STRUCT;
 					} else {