2
0
Эх сурвалжийг харах

Merge pull request #81105 from SysError99/master-fix-js-mem-leak

Fix JavaScript callback memory leak issue
Rémi Verschelde 2 жил өмнө
parent
commit
2cd740fd7a

+ 3 - 1
platform/web/js/libs/library_godot_javascript_singleton.js

@@ -210,7 +210,9 @@ const GodotJSWrapper = {
 			// This is safe! JavaScript is single threaded (and using it in threads is not a good idea anyway).
 			GodotJSWrapper.cb_ret = null;
 			const args = Array.from(arguments);
-			func(p_ref, GodotJSWrapper.get_proxied(args), args.length);
+			const argsProxy = GodotJSWrapper.MyProxy(args);
+			func(p_ref, argsProxy.get_id(), args.length);
+			argsProxy.unref();
 			const ret = GodotJSWrapper.cb_ret;
 			GodotJSWrapper.cb_ret = null;
 			return ret;