Browse Source

Merge pull request #65161 from m4gr3d/fix_android_build_failures_on_windows_main

Fix build failures for Android on Windows
Clay John 3 years ago
parent
commit
7061adf24f
1 changed files with 11 additions and 10 deletions
  1. 11 10
      methods.py

+ 11 - 10
methods.py

@@ -412,16 +412,17 @@ def use_windows_spawn_fix(self, platform=None):
 
 
         startupinfo = subprocess.STARTUPINFO()
         startupinfo = subprocess.STARTUPINFO()
         startupinfo.dwFlags |= subprocess.STARTF_USESHOWWINDOW
         startupinfo.dwFlags |= subprocess.STARTF_USESHOWWINDOW
-        proc = subprocess.Popen(
-            cmdline,
-            stdin=subprocess.PIPE,
-            stdout=subprocess.PIPE,
-            stderr=subprocess.PIPE,
-            startupinfo=startupinfo,
-            shell=False,
-            env=env,
-            text=True,
-        )
+        popen_args = {
+            "stdin": subprocess.PIPE,
+            "stdout": subprocess.PIPE,
+            "stderr": subprocess.PIPE,
+            "startupinfo": startupinfo,
+            "shell": False,
+            "env": env,
+        }
+        if sys.version_info >= (3, 7, 0):
+            popen_args["text"] = True
+        proc = subprocess.Popen(cmdline, **popen_args)
         _, err = proc.communicate()
         _, err = proc.communicate()
         rv = proc.wait()
         rv = proc.wait()
         if rv:
         if rv: