浏览代码

Merge pull request #55358 from timothyqiu/pop-front-3.x

[3.x] Fix potential infinite loop when connecting HTTPClient
Rémi Verschelde 3 年之前
父节点
当前提交
c4f7ba4686
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      core/io/http_client.cpp

+ 1 - 1
core/io/http_client.cpp

@@ -337,7 +337,7 @@ Error HTTPClient::poll() {
 
 					Error err = ERR_BUG; // Should be at least one entry.
 					while (ip_candidates.size() > 0) {
-						err = tcp_connection->connect_to_host(ip_candidates.front(), conn_port);
+						err = tcp_connection->connect_to_host(ip_candidates.pop_front(), conn_port);
 						if (err == OK) {
 							break;
 						}